[haiku-commits] Re: r40520 - in haiku/trunk/src: add-ons/kernel/drivers/graphics/radeon_hd tests/kits/net/preflet/InterfacesAddOn

  • From: Alexander von Gluck <kallisti5@xxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 16 Feb 2011 10:04:17 -0600

On Wed, 2011-02-16 at 15:25 +0100, Axel Dörfler wrote:
> Alexander von Gluck<kallisti5@xxxxxxxxxxx> wrote:
> > I know this, but based on your previous comments on my commit that
> > added the style violation in the first place you mentioned:
> > 
> >  "Same here, really, great commit! :-/"
> > 
> > That sounded like you wanted to avoid smaller commits.  I normally make
> > independent commits for independent code areas. Miscommunication I
> > guess on my part.
> What I meant with "really, great commit" was that it mostly introduced style 
> violations that I have at least mentioned once to you before. I have a hard 
> time understanding when someone repeats a mistake that has been pointed out 
> previously; I guess I would be a great teacher ;-)

Fair enough, my style violations are going down in number quite a bit
based on commited code volume though.

> > > BTW did you not see this mail:
> [...]
> > I implemented the grid layout. I have one last small re-factoring to do
> > though on the really good feedback provided by Alex Wilson on  Tue, 15
> > Feb 2011 16:32:11 to use the templatized layout builders in
> > <LayoutBuilder.h> instead of the grid layout.
> Yeah, noticed that as well afterwards, sorry for the noise.
> BTW "I cannot implement something I do not know" is a poor excuse for not 
> investigating better beforehand. I know that our API is currently not as 
> clean as it used to be, but that makes it even more important to learn by 
> example (ie. an application that makes good use of the layout functionality).

Your right, it's not an excuse. There is also a lot of documentation
starting to form on this layout stuff as well...

In my defense though... this stuff is still pretty young.

 -Alexander von Gluck IV

Other related posts: