[haiku-commits] Re: r40520 - in haiku/trunk/src: add-ons/kernel/drivers/graphics/radeon_hd tests/kits/net/preflet/InterfacesAddOn
- From: "Jonas Sundström" <jonas@xxxxxxxxxxx>
- To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
- Date: Thu, 17 Feb 2011 02:22:10 +0100
Jérôme Duval Jérôme Duval <korli@xxxxxxxxxxxxxxxx> wrote:
> 2011/2/16 Jonas Sundström <jonas@xxxxxxxxxxx>:
> > When when studying a body of code, perhaps even the style guide,
> > it is seldom possible to see and absorb all of its properties
> > all at once. No matter how clean the API is or how clear the
> > style guide is made it is safe to assume that every new committer
> > and even older ones, returning ones, will make mistakes.
>
> I guess you forgot the time involved in reviewing and pointing such mistakes.
> When there is no improvement, I'm really tempted to not review and
> comment any more.
> Thanks for the rant.
You're right, it was a rant.
I understand the necessity of code review, and that giving
feedback is often a thankless task.
I'm embarrased to say that I don't review commits. So I am not
in a position to argue that the reviews are unfair, or that they
should be some other way. For having done so, I apologize.
/Jonas.
Other related posts:
