[haiku-commits] Re: r40520 - in haiku/trunk/src: add-ons/kernel/drivers/graphics/radeon_hd tests/kits/net/preflet/InterfacesAddOn
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Thu, 17 Feb 2011 09:27:02 +0100 (MET)
Jonas Sundström<jonasjavascript:msgAction('send');@kirilla.com> wrote:
> Jérôme Duval Jérôme Duval <korli@xxxxxxxxxxxxxxxx> wrote:
> > I guess you forgot the time involved in reviewing and pointing such
> > mistakes.
Indeed, however...
> I understand the necessity of code review, and that giving
> feedback is often a thankless task.
>
> I'm embarrased to say that I don't review commits. So I am not
> in a position to argue that the reviews are unfair, or that they
> should be some other way. For having done so, I apologize.
... I think it's perfectly okay to point out things one finds unfair, even if
you might not have taken the full picture into account. I know I am sometimes a
bit too "direct" in my criticism, and mentioning that from time to time
certainly doesn't harm.
Bye,
Axel.
Other related posts:
