On Wed, 16 Feb 2011 09:38:16 +0100 (MET) "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx> wrote: > kallisti5@xxxxxxxxxxx wrote: > > Log: > > radeon_hd: small style header style fixes as per axel-- > > networkSetup: prevented enable/disable button from hiding; disable > > configure button if interface is disabled; add configuration mode > > dropdown (auto(dhcp)/static); make address fields disable (with > > curent settings shown) if auto-config is selected; style cleanup > > Thanks, but please don't throw completely unrelated changes into a > single commit. With SVN you can directly define which changes you > want to commit (on a per file basis), just add the path like this, > for example: svn co src/tests/ I know this, but based on your previous comments on my commit that added the style violation in the first place you mentioned: "Same here, really, great commit! :-/" That sounded like you wanted to avoid smaller commits. I normally make independent commits for independent code areas. Miscommunication I guess on my part. > BTW did you not see this mail: > //www.freelists.org/post/haiku-commits/r40500-haikutrunksrctestskitsnetprefletInterfacesAddOn,2 > ?. Did you see this email? //www.freelists.org/post/haiku-commits/r40500-haikutrunksrctestskitsnetprefletInterfacesAddOn,3 I implemented the grid layout. I have one last small re-factoring to do though on the really good feedback provided by Alex Wilson on Tue, 15 Feb 2011 16:32:11 to use the templatized layout builders in <LayoutBuilder.h> instead of the grid layout. Thanks! -- Alex