[haiku-commits] Re: r35769 - in haiku/trunk/src/add-ons/translators: exr gif ppm raw shared ...
- From: Stephan Assmus <superstippi@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sat, 06 Mar 2010 10:45:36 +0100
On 2010-03-06 at 09:48:37 [+0100], Stephan Assmus <superstippi@xxxxxx> wrote:
>
> On 2010-03-06 at 05:45:43 [+0100], leavengood@xxxxxxxxx wrote:
> > Author: leavengood
> > Date: 2010-03-06 05:45:43 +0100 (Sat, 06 Mar 2010)
> > New Revision: 35769
> > Changeset: http://dev.haiku-os.org/changeset/35769/haiku
> > Ticket: http://dev.haiku-os.org/ticket/2117
> >
> > Modified:
> > haiku/trunk/src/add-ons/translators/exr/ConfigView.cpp
> > haiku/trunk/src/add-ons/translators/exr/ConfigView.h
> > haiku/trunk/src/add-ons/translators/exr/EXRTranslator.cpp
> > haiku/trunk/src/add-ons/translators/exr/main.cpp
> > haiku/trunk/src/add-ons/translators/gif/GIFTranslator.cpp
> > haiku/trunk/src/add-ons/translators/gif/GIFView.cpp
> > haiku/trunk/src/add-ons/translators/gif/GIFView.h
> > haiku/trunk/src/add-ons/translators/gif/GIFWindow.cpp
> > haiku/trunk/src/add-ons/translators/ppm/PPMMain.cpp
> > haiku/trunk/src/add-ons/translators/ppm/PPMTranslator.cpp
> > haiku/trunk/src/add-ons/translators/raw/ConfigView.cpp
> > haiku/trunk/src/add-ons/translators/raw/ConfigView.h
> > haiku/trunk/src/add-ons/translators/raw/RAWTranslator.cpp
> > haiku/trunk/src/add-ons/translators/raw/main.cpp
> > haiku/trunk/src/add-ons/translators/shared/BaseTranslator.cpp
> > haiku/trunk/src/add-ons/translators/shared/TranslatorWindow.cpp
> > haiku/trunk/src/add-ons/translators/shared/TranslatorWindow.h
> > haiku/trunk/src/add-ons/translators/tga/TGAMain.cpp
> > haiku/trunk/src/add-ons/translators/tga/TGATranslator.cpp
> > haiku/trunk/src/add-ons/translators/tga/TGAView.cpp
> > haiku/trunk/src/add-ons/translators/tga/TGAView.h
> > haiku/trunk/src/add-ons/translators/tiff/TIFFMain.cpp
> > haiku/trunk/src/add-ons/translators/tiff/TIFFTranslator.cpp
> > haiku/trunk/src/add-ons/translators/tiff/TIFFView.cpp
> > haiku/trunk/src/add-ons/translators/tiff/TIFFView.h
> > Log:
> > Apply patch from Maxime Simon to make several translators use the Layout
> > API.
> > There are a few small changes from myself, such as adding a copyright for
> > Maxime in files with bigger changes. Also because this patch was so old I
> > had
> > to do some manual patching, and added back the title and description on
> > the
> > TGA
> > and TIFF translators.
> >
> > I think this improves things a lot, though there is still some work to do
> > to
> > improve the consistency of the translator settings views.
> >
> > I think this mostly fixes #2117, though I may leave the ticket open until
> > a
> > few
> > more things are resolved.
>
> IIRC, there were some problems with this patch, which is why I didn't apply
> it back then. If memory serves, one problem is that other applications can
> ask for the Translator configuration view, these views are not just embedded
> into the DataTranslations preflet. Have you tested this situation?
Just saw in the ticket, that Maxime apparently found a solution for this
problem. Don't know if that was already contained in the patch or not, but it
probably was. It's probably good to have the patch commited, if there are
indeed problems left, they have a greater chance of getting fixed now. ;-)
Best regards,
-Stephan
Other related posts:
