[haiku-commits] Re: r35085 - in haiku/trunk/src: kits/tracker system/libroot/os

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 15 Jan 2010 16:00:38 +0100

Rene Gollent <anevilyak@xxxxxxxxx> wrote:
> On Fri, Jan 15, 2010 at 8:30 AM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
> > wrote:
> > Besides the general attribute issue with multi-user, maybe it would
> > make more sense to use a standard folder icon for the trash, as you
> > cannot know the contents of the trash of the other users.
> Even on the Desktop?

No, of course not :-)
Maybe a standard folder with a small trash overlay could be used.
Alternatively, we could introduce hiding them again ;-)
At least I just updated to the latest revision, and it is a bit odd to
have the trash everywhere.

> > Not sure what you are referring here exactly. What possible
> > performance
> > problems do you see because of what change?
> Given how Tracker currently adds poses to a directory, hiding that
> particular one would require a change in BPoseView::ShouldShowPose(),
> which is invoked for every pose that gets added. Ergo, if I wanted to
> do something like check if the pose is the trash dir and not add it,
> that would entail running that filter against every single pose in
> the
> dir. Hence the concern. The old fInvisiblePose check was
> (comparatively) cheap since the PoseInfo has to be read for every
> entry anyways to determine its icon location.

I wouldn't mind using that same method for the trash again. That would
also lift the need for renaming it to "trash" :-)
I also think we should move the "var" directory into common/. It doesn't
really make much sense on the top level. I will take care of that in
the next few days if no one objects.

> > "fat".
> Will update that, thanks.



Other related posts: