[haiku-commits] Re: r35085 - in haiku/trunk/src: kits/tracker system/libroot/os
- From: Rene Gollent <anevilyak@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 15 Jan 2010 08:35:19 -0600
On Fri, Jan 15, 2010 at 8:30 AM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
> Besides the general attribute issue with multi-user, maybe it would
> make more sense to use a standard folder icon for the trash, as you
> cannot know the contents of the trash of the other users.
Even on the Desktop?
> At least in Haiku you could actually delete the Trash directory from
> your Desktop, though :-)
> Not that I would miss that.
True, but I could just as easily make it a preference option to just
not show it on the desktop at all :) The code that adds the fake pose
would be quite trivial to not execute based on a setting.
> Which could be a genuine Model feature then, I think.
Will look into that then.
> Not sure what you are referring here exactly. What possible performance
> problems do you see because of what change?
Given how Tracker currently adds poses to a directory, hiding that
particular one would require a change in BPoseView::ShouldShowPose(),
which is invoked for every pose that gets added. Ergo, if I wanted to
do something like check if the pose is the trash dir and not add it,
that would entail running that filter against every single pose in the
dir. Hence the concern. The old fInvisiblePose check was
(comparatively) cheap since the PoseInfo has to be read for every
entry anyways to determine its icon location.
>
> "fat".
Will update that, thanks.
Regards,
Rene
Other related posts:
