[haiku-commits] Re: r35085 - in haiku/trunk/src: kits/tracker system/libroot/os
- From: Stephan Assmus <superstippi@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 15 Jan 2010 10:35:53 +0100
On 2010-01-15 at 06:12:46 [+0100], anevilyak@xxxxxxxxx wrote:
> Author: anevilyak
> Date: 2010-01-15 06:12:45 +0100 (Fri, 15 Jan 2010) New Revision: 35085
> Changeset: http://dev.haiku-os.org/changeset/35085/haiku Ticket:
> http://dev.haiku-os.org/ticket/5245
>
> Modified:
> haiku/trunk/src/kits/tracker/Attributes.h
> haiku/trunk/src/kits/tracker/ContainerWindow.cpp
> haiku/trunk/src/kits/tracker/ContainerWindow.h
> haiku/trunk/src/kits/tracker/DeskWindow.cpp
> haiku/trunk/src/kits/tracker/DeskWindow.h
> haiku/trunk/src/kits/tracker/DesktopPoseView.cpp
> haiku/trunk/src/kits/tracker/DesktopPoseView.h
> haiku/trunk/src/kits/tracker/DirMenu.cpp
> haiku/trunk/src/kits/tracker/FSUtils.cpp
> haiku/trunk/src/kits/tracker/FSUtils.h
> haiku/trunk/src/kits/tracker/FilePanelPriv.cpp
> haiku/trunk/src/kits/tracker/Model.cpp
> haiku/trunk/src/kits/tracker/Model.h
> haiku/trunk/src/kits/tracker/PoseView.cpp
> haiku/trunk/src/kits/tracker/PoseView.h
> haiku/trunk/src/kits/tracker/Tracker.cpp
> haiku/trunk/src/kits/tracker/TrashWatcher.cpp
> haiku/trunk/src/system/libroot/os/find_directory.c
> Log:
> More Tracker refactoring:
> * relocated Trash dirs to volume roots by modifying find_directory() to
> report the trash location as volume/Trash.
> * FSUtils no longer creates /home/Desktop on every volume.
> * TrashWatcher now keeps icons in sync on all volumes.
> * Simplified FSGetDeskDir since it no longer has to worry about getting
> the desk directory on any volume other than the root.
> * Relocated trash context menu logic to BContainerWindow so it can also
> be used at the volume roots.
> * DesktopPoseView now creates a virtual Trash pose representing the
> trash contents as before.
> * Corrected typo: Model::WriteAttrKillForegin() ->
> Model::WriteAttrKillForeign().
>
> Closes ticket #5245.
I love it! Great work. Finally I can just put folders on my non-boot
volumes without this extra "home" level. On the boot volume, capitalized
"Trash" sticks out a bit. On my other volumes, not so much. But I agree
with Axel that we usually have all system folders lower-case. I'm guessing
it wouldn't be a big change. Maybe it's even good that then there will be a
difference between the unified "Trash" on the Desktop and "trash" on the
volumes.
Best regards,
-Stephan
Other related posts:
