[hipl-dev] Re: [Merge] lp:~hipl-core/hipl/libhip into lp:hipl

  • From: Diego Biurrun <diego@xxxxxxxxxx>
  • To: hipl-dev@xxxxxxxxxxxxx
  • Date: Thu, 09 Feb 2012 16:23:46 +0100

On Thu, Feb 09, 2012 at 04:54:32PM +0200, Xin Gu wrote:
> On 08/02/12 20:00, Diego Biurrun wrote:
> >On Wed, Feb 08, 2012 at 08:43:18AM +0000, Xin wrote:
> >>
> >>--- Makefile.am     2012-01-30 12:28:31 +0000
> >>+++ Makefile.am     2012-02-07 15:20:56 +0000
> >>@@ -64,19 +65,22 @@
> >>
> >>  ### libraries ###
> >>  lib_LTLIBRARIES = lib/core/libhipcore.la
> >>-
> >>+lib_LTLIBRARIES += lib/hipdaemon/libhipdaemon.la
> >>
> >>  ### tests ###
> >Oh, the poor empty line ...
> Fixed, I didn't notice that there is a style for empty lines

You shouldn't unintentionally mess with the style of a file.

> >>  if HIP_UNITTESTS
> >>-TESTS           = test/check_hipd     \
> >>-                  test/check_hipfw    \
> >>-                  test/check_lib_core \
> >>-                  test/check_lib_tool \
> >>+TESTS           = test/check_hipd       \
> >>+                  test/check_hipfw      \
> >>+                  test/check_hipnetcat  \
> >>+                  test/check_lib_core   \
> >>+                  test/check_lib_tool   \
> >>                    test/check_modules_midauth
> >>-check_PROGRAMS  = test/check_hipd     \
> >>-                  test/check_hipfw    \
> >>-                  test/check_lib_core \
> >>-                  test/check_lib_tool \
> >>+
> >>+check_PROGRAMS  = test/check_hipd       \
> >>+                  test/check_hipfw      \
> >>+                  test/check_hipnetcat  \
> >>+                  test/check_lib_core   \
> >>+                  test/check_lib_tool   \
> >>                    test/check_modules_midauth
> >>  endif
> >Having to realign all those backslashes is suboptimal.  I'll move them
> >all to a sensible position in trunk.
> I merged your newest change, which align to column 72, but some new
> contents in libhip are long than 72. I align those longer lines to 84

Try to keep lines below 80 characters where easily possible.

And please leave empty lines before and after your text, your mails
are currently unnecessarily hard to read.

Diego

Other related posts: