[hipl-dev] What is the standard process for code review?

  • From: Xin Gu <eric.nevup@xxxxxxxxx>
  • To: hipl-dev@xxxxxxxxxxxxx
  • Date: Fri, 10 Feb 2012 14:40:12 +0200

Hi,

Since I am new here, I was wondering what is the proper process for the merge review.

I have received comments requiring further fixing (Needs fixing), and now I finished the code fixing. In this case, should I close current merge process and propose another round of merge, or there is other standard process?

The link to the merge proposal: https://code.launchpad.net/~hipl-core/hipl/libhip/+merge/91407 <https://code.launchpad.net/%7Ehipl-core/hipl/libhip/+merge/91407> always shows diff result up to date, but without a new review, people won't receive email with diff result inside.

Thanks a lot

Xin Gu

Other related posts: