[yoshimi] Re: Copy/Paste bug fixing, improvements

  • From: Will Godfrey <willgodfrey@xxxxxxxxxxxxxxx>
  • To: yoshimi@xxxxxxxxxxxxx
  • Date: Sun, 27 Dec 2015 22:42:42 +0000

On Sun, 27 Dec 2015 11:47:00 +0100
Csaba Erdei <csaba.erdei@xxxxxxxxxx> wrote:

Hi All,

As I see copy to clipboard and paste from clipboard works, however
saving and loading presets do not.

What I did:

1. Edit->ADDsynth Edit->Show Voice Parameters->Current voice 1->C->Copy
to Preset then named my preset int the text entry field as abcd

2. Current voice 2->P but I do not see my preset abcd in the list.
However a file appeared in presets dir called abcd.ADnoteParametersn.xpz

I have a preset called ResetGlobal.ADnoteParameters.xpz for AddSynth
Global, and it appears in the list, but it is not applicable here.

Copy to Clipboard and Paste from Clipboard does not work for modulation
settings. Maybe it should have different C/P buttons?

It seems to me a bug and some usability problem.

Do you use or test regularly this functionality? Did you see bugs like
this somewhere else?

I plan to add system clipboard integration as a ccmake option which is
off by default. It is might my personal working style only that I like
to see the world trough ssh and vi editor but this minor optional code
does not make much confusion.

Regards,

Csaba Erdei



On 12/26/2015 11:44 PM, Will Godfrey wrote:
On Thu, 24 Dec 2015 17:48:51 +0100
Csaba Erdei <csaba.erdei@xxxxxxxxxx> wrote:

Dear All,

I am an IT professional and hobby musician and I am interested in
Yoshimi development. I would be happy to contribute to the MIDI learn
feature and improving copy/paste presets. Do you know that someone
started working on them already? Do you have any concept, idea or
requirement about these?

Thanks and Regards,

Csaba Erdei
Hi... again :)

From a usability point of view I much prefer the appearance of the first
midi learn attempt - I've placed it in a separate branch: 1.0-midi-learn

However it is well out of date, and also had some bad implementation issues.

As well as clear indication of what has been set, it gives you the
opportunity
to change the min/max values, and even make min > max, thus reversing the
effect of the control.

It also allows you the have one CC attached to several actual controls.

Instead of MusicIO, the pickup point should be in SynthEngine.cpp ->
SynthEngine::SetController(

This is for several reasons. The first is that it then can't interfere with
root/bank/program changes. Also, at this point pitch wheel, Channel and key
pressure have all been converted to accessible CCs.

Finally, it will be able to pick up vector controls and re-route them to
other
effects - this will (eventually) massively expand the vector control
features!



Copy and paste is far more sophisticated than a lot of people realise,
although
I agree that the interface is not very friendly. I don't think people
realise
that when pasting, you only get shown the the presets that are relevant to
that
part of the synth. I rather think that 'presets' is the wrong word here, as
people are likely to confuse it with the effects presets.

The way it works is to store a 'copy' as an XML stub, which can either be
pasted
elsewhere or stored to file with an appropriate header. When you pick one
from
file it simply reverses the process.


Just rechecked this (I'd done some work to clear bugs a few months ago)
copy/paste to clipboard seems to work OK here. Sub & Pad seem OK sending to
file. Add global also seems fine. It seemed to include the modulation effects.

It's a bit strange about the voice one. The fault is not in the saving, but the
loading which is supposed to recognise that extra 'n' as meaning just a single
voice.

--
Will J Godfrey
http://www.musically.me.uk
Say you have a poem and I have a tune.
Exchange them and we can both have a poem, a tune, and a song.
Yoshimi source code is available from either:
http://sourceforge.net/projects/yoshimi
Or: https://github.com/Yoshimi/yoshimi
Our list archive is at: https://www.freelists.org/archive/yoshimi
To post, email to yoshimi@xxxxxxxxxxxxx

Other related posts: