[TextEditor_mcc] type usage in amiga sources
- From: Gunther Nikl <gni@xxxxxxxx>
- To: texteditor_mcc@xxxxxxxxxxxxx
- Date: Thu, 7 Jul 2005 14:16:09 +0200
Hello!
I just noticed a change to "betterstring/mcc/hotkeystring/HandleInput.c"
where "char" was replaced with (CONST_)STRPTR. IMHO this was a wrong
change and unnecessary.
I know that every system uses a different GCC version with different
defaults for char signedness (OS4: 3.4.x,4.0; MOS: 2.95.3; 68k: 2.95.x,
3.3.x, 3.4.x, 4.x). Especially GCC4 can be annoying with its pointer
signedness warnings. And this change in hotkeystring/HandleInput.c
introduces such warnings since CONST_STRPTR is with the 3.9 NDK exec/types.h
"unsigned char *" (3.5 had "char *"). Mix this with standard "char" (thats
what most standard functions use) and you get nasty results. Thus I think
"char *" was the right choice in this case and I think "CONST CONST_STRPTR"
looks rather strange ;-)
I know that the AmigaOS API uses UBYTE and STRPTR and thus conflicts can't
be avoided.
Gunther
--
Linux is only free if your time has no value
- Jamie Zawinski
_____________________________________________________________________________
TextEditor ML - //www.freelists.org/list/texteditor_mcc
Listserver help - mailto:texteditor_mcc-request@xxxxxxxxxxxxx?Subject=HELP
Bugtracker......: http://sourceforge.net/tracker/?atid=731469&group_id=135025
Other related posts:
