[TextEditor_mcc] Re: type usage in amiga sources

  • From: Ilkka Lehtoranta <ilkleht@xxxxxxxxxxx>
  • To: texteditor_mcc@xxxxxxxxxxxxx
  • Date: Thu, 7 Jul 2005 23:05:58 +0300 (EEST)

On Thu, 7 Jul 2005, Gunther Nikl wrote:

> Hello!
> I just noticed a change to "betterstring/mcc/hotkeystring/HandleInput.c"
> where "char" was replaced with (CONST_)STRPTR. IMHO this was a wrong
> change and unnecessary.
> I know that every system uses a different GCC version with different
> defaults for char signedness (OS4: 3.4.x,4.0; MOS: 2.95.3; 68k: 2.95.x,
> 3.3.x, 3.4.x, 4.x). Especially GCC4 can be annoying with its pointer

Strange compilers you are using. Cant you all default to GCC2? :-) Works 
stable and produces identical code ;) Okay, restored and committed.
CONST CONST_STRPTR is mostly cosmetical.

> signedness warnings. And this change in hotkeystring/HandleInput.c
> introduces such warnings since CONST_STRPTR is with the 3.9 NDK exec/types.h
> "unsigned char *" (3.5 had "char *"). Mix this with standard "char" (thats
> what most standard functions use) and you get nasty results. Thus I think
> "char *" was the right choice in this case and I think "CONST CONST_STRPTR"
> looks rather strange ;-)

There probably should be standard CodingStyle doc? I had no idea of char 
madness (in fact never did much of C coding on 3.x).

TextEditor ML   - http://www.freelists.org/list/texteditor_mcc
Listserver help - mailto:texteditor_mcc-request@xxxxxxxxxxxxx?Subject=HELP
Bugtracker......: http://sourceforge.net/tracker/?atid=731469&group_id=135025

Other related posts: