Re: [PATCH] allow setting LDFLAGS from pci-userspace Makefile

  • From: Antti Kantee <pooka@xxxxxx>
  • To: rumpkernel-users@xxxxxxxxxxxxx
  • Date: Sun, 16 Aug 2015 11:34:42 +0000

On 16/08/15 11:28, Robert Millan wrote:

On 16/08/15 13:24, Antti Kantee wrote:
Component-specific flags. Specifically -lpciaccess on GNU/Hurd. See my more
recent
mails about this.

You still need to supply -lpciaccess "manually" if you want to link a static
rump kernel.

I'm not sure I follow. Please correct me if I missunderstood, but what I see is
that
the Makefile in libpci (buildrump.sh tree) is the one actually building and
linking of
OS-specific code in pci-userspace.

Therefore the Makefile in pci-userspace needs to pass along its requirements by
exporting
some variables.

Is that correct?

Shared libraries are linked when they are created, static libraries are just archived. There is linking happening in libpci in the latter case and hence LDFLAGS is not used.

Does the build of libpci on Hurd fail if you don't supply the additional LDFLAGS?


btw, I'm going to yank bus_space and bus_dma out of libpci into separate components in the very near future. Some ARM boards don't need to do PCI, but they do need to do at least bus_space, and possibly bus_dma.

Other related posts: