Re: [PATCH] allow setting LDFLAGS from pci-userspace Makefile
- From: Robert Millan <rmh@xxxxxxx>
- To: pooka@xxxxxx, rumpkernel-users@xxxxxxxxxxxxx
- Date: Sat, 29 Aug 2015 22:58:36 +0200
El 28/08/15 a les 23:00, Antti Kantee ha escrit:
[...], I'm sure Hurd users are expert enough to figure out a missing
libpciaccess.
Well most of them "users" building things are actually distributors like Debian,
and then they're always using shared libraries.
For expert users building their own stuff, and doing it statically, I guess
it's fair
to expect them to provide the missing flags.
Anyway, like I said earlier, if you think it's better to link against
libpciaccess for shared libs, please go right ahead.
Ok. For that I need a small change in buildrump.sh to propagate flags defined by
pci-userspace (if any). See attachment.
I was just trying to find a systematic error in how rump kernel components are
produced, and based on this discussion I couldn't find one.
Understood.
Maybe it should be using pkg-config then?
No strong feelings this way or that way. Go ahead if you think it suits your
use case.
I was assuming you'd want that. But if you're fine with just linking against
libpciaccess, then so am I :-)
--
Robert Millan
Index: rumpkernel-0~20150715/buildrump.sh/src/sys/rump/dev/lib/libpci/Makefile
===================================================================
--- rumpkernel-0~20150715.orig/buildrump.sh/src/sys/rump/dev/lib/libpci/Makefile
+++ rumpkernel-0~20150715/buildrump.sh/src/sys/rump/dev/lib/libpci/Makefile
@@ -37,6 +37,7 @@ RUMPCOMP_USER_CPPFLAGS+=${RUMPCOMP_USER_
RUMPCOMP_USER_CFLAGS= ${RUMPCOMP_USER_CFLAGS.rumpdev_pci}
CPPFLAGS+= ${RUMPCOMP_CPPFLAGS.rumpdev_pci}
+LDFLAGS+= ${RUMPCOMP_LDFLAGS.rumpdev_pci}
# XXX: messy
.undef RUMPKERN_ONLY
Other related posts:
