Re: [PATCH] allow setting LDFLAGS from pci-userspace Makefile

  • From: Robert Millan <rmh@xxxxxxx>
  • To: pooka@xxxxxx, rumpkernel-users@xxxxxxxxxxxxx
  • Date: Fri, 28 Aug 2015 18:48:29 +0200

El 25/08/15 a les 23:16, Antti Kantee ha escrit:

So? For example, rumpdev_pci doesn't link against rumpdev (why else are you
specifying -lrumpdev or -lrump for that matter?).

Same reason. Except here it isn't a problem because I can just add them
unconditionally when building the end user of librumpdev_pci.

If Hurd cares only about shared libraries, go ahead, your proposal has no
downsides. I'm just saying that things will break for static linking unless
you carry the dependency chain over to the executable link phase.

Okay, I see your point now. I admit to being a bit careless about static
linking, but this is just my bias (not a Hurd thing AFAIK).

So how does the end user of librumpdev_pci know whether additional libraries
(e.g. -lpciaccess) are needed on this platform?

Maybe it should be using pkg-config then?

--
Robert Millan

Other related posts: