Hi,
All review materials (license, security, user experience) passes.
A possible suggestion for 2.0: it should be possible for the add-on installer
to keep the old tdf files when installing new add-on releases (this involves
creating installTasks.py).
If you believe it is ready for stable branch, then I'll go ahead and make it
available under the stable tag for now (I'm facing difficulty in trying to make
it work under translations workflow at this point due to redesign of Bitbucket).
Cheers,
Joseph
-----Original Message-----
From: nvda-addons-bounce@xxxxxxxxxxxxx
[mailto:nvda-addons-bounce@xxxxxxxxxxxxx] On Behalf Of Hrvoje Katic
Sent: Wednesday, July 20, 2016 2:45 AM
To: nvda-addons@xxxxxxxxxxxxx
Subject: [nvda-addons] Re: Tone master 1.1
A major issue has now been fixed in 1.2. Thanks, Josef!
https://github.com/nvdaaddons/toneMaster/releases/download/v1.2/toneMaster-1.2.nvda-addon
"Joseph Lee" <joseph.lee22590@xxxxxxxxx> wrote:
Hi,
Review results:
* Licensing: pass (carried from previous version)
* Security: pass (thanks for addressing some issues).
* User experience: pass with caution.
The way it was done was to review the diff between 1.0 and 1.1.
Comments:
* Possible bug found: if you create an empty tone data file, select
it, attempt to play it, then select another one, NVDA will not play the newly
chosen tone data (will file a bug report on GitHub).
I recommend a green light once major bugs are resolved. Thanks. Reviews form
others are appreciated.
Cheers,
Joseph
----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for reporting
bugs.
Community addons are available from: http://addons.nvda-project.org To send a ;
message to the list: nvda-addons@xxxxxxxxxxxxx To change your list
settings/unsubscribe: //www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for reporting bugs.
Community addons are available from: http://addons.nvda-project.org
To send a message to the list: nvda-addons@xxxxxxxxxxxxx
To change your list settings/unsubscribe:
//www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
