Hello,
This was suggested by someone else, but unfortunately this will not be
possible until NVDA will be able to output itself into audio files.
Lawrence Perez <lawrenceperez2010@xxxxxxxxx> wrote:
Found yet another bug with Tone master 1.2.
Due to my soundcard, when playing a tone data file, there's some times is a
large gap between beeps. To fix this issue, I recommend playing a wave file in
the background that has nothing but silence in it. Audacity is a good audio
editing tool that is open source, that's accessible with NVDA, and can help you
create this silence wave file. As soon as the silence wave file starts playing,
tone master should start playing the beeps. Please note, the reason I
mentioning playing a wave file in the background is because when I play a
silent wave file in a media player such as VLC media player, the issue seems to
go away for me. So, have tone master play the silent wave file as well as beep,
if possible. Whenever it's finished beeping, have it stop playing the silent
file. Also, make the sound file loop over and over because some files can be
longer then the specified wave file duration. This way, Nohe large gaps are
noticeable.
Also, a suggestion for in the future. How about when you create these tones
files, having it saved to a wave file? And thinking of a shortcut like NVDA
plus all plus S, or something similar, so that you can choose a file location
and file name, and save it as a standard wave file they can be played in an
audio editor like audacity or in media player like VLC media player.
Sent from my iPhone
On Jul 20, 2016, at 4:50 AM, Hrvoje Katic <hrvojekatic@xxxxxxxxx> wrote:----------------------------------------------------------------
Hello,
I believe there are no issues left that I'm aware of. However, as you've
said, tdf files must be backed up manually before reinstallation or
uninstallation at this time, otherwise they will be lost permanently.
The next update will have automatic silent backup procedure, at least
for reinstallation cause I think it's not needed for uninstallation. If
people uninstall something, it's expected that they will not use it
anymore, so in that case backup is not needed.
"Joseph Lee" <joseph.lee22590@xxxxxxxxx> wrote:
Hi,
All review materials (license, security, user experience) passes.
A possible suggestion for 2.0: it should be possible for the add-on installer
to keep the old tdf files when installing new add-on releases (this involves
creating installTasks.py).
If you believe it is ready for stable branch, then I'll go ahead and make it
available under the stable tag for now (I'm facing difficulty in trying to
make it work under translations workflow at this point due to redesign of
Bitbucket).
Cheers,
Joseph
-----Original Message-----
From: nvda-addons-bounce@xxxxxxxxxxxxx
[mailto:nvda-addons-bounce@xxxxxxxxxxxxx] On Behalf Of Hrvoje Katic
Sent: Wednesday, July 20, 2016 2:45 AM
To: nvda-addons@xxxxxxxxxxxxx
Subject: [nvda-addons] Re: Tone master 1.1
A major issue has now been fixed in 1.2. Thanks, Josef!
https://github.com/nvdaaddons/toneMaster/releases/download/v1.2/toneMaster-1.2.nvda-addon
"Joseph Lee" <joseph.lee22590@xxxxxxxxx> wrote:
Hi,
Review results:
* Licensing: pass (carried from previous version)
* Security: pass (thanks for addressing some issues).
* User experience: pass with caution.
The way it was done was to review the diff between 1.0 and 1.1.
Comments:
* Possible bug found: if you create an empty tone data file, select
it, attempt to play it, then select another one, NVDA will not play the newly
chosen tone data (will file a bug report on GitHub).
I recommend a green light once major bugs are resolved. Thanks. Reviews form
others are appreciated.
Cheers,
Joseph
----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for reporting
bugs.
Community addons are available from: http://addons.nvda-project.org To send a ;
message to the list: nvda-addons@xxxxxxxxxxxxx To change your list
settings/unsubscribe: //www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for reporting
bugs.
Community addons are available from: http://addons.nvda-project.org
To send a message to the list: nvda-addons@xxxxxxxxxxxxx
To change your list settings/unsubscribe:
//www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for reporting
bugs.
Community addons are available from: http://addons.nvda-project.org
To send a message to the list: nvda-addons@xxxxxxxxxxxxx
To change your list settings/unsubscribe:
//www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
