Hi Bert, I think I have covered all the things that are needed for this rfe. When you have some time could you please have a look, I would value any comments/suggestions. It should also be much cleaner to add the typeform test that you needed some time ago. thanks, Mesar On Sat 06/09/14,13:28, Mesar Hameed wrote: > Branch: refs/heads/mhameed_runharness_compact_output > Home: https://github.com/liblouis/liblouis > Commit: 553bdb51b339386e7ac7a267565eea6aa43766d1 > > https://github.com/liblouis/liblouis/commit/553bdb51b339386e7ac7a267565eea6aa43766d1 > Author: Mesar Hameed <mesar.hameed@xxxxxxxxx> > Date: 2014-09-06 (Sat, 06 Sep 2014) > > Changed paths: > M tests/harness/runHarness.py > > Log Message: > ----------- > tests/harness/runHarness.py: deduplicate error reporting code. > > Also seems to have a performance improvement. > This is due to not needing to building up error message strings for tests > that pass. > > assert a == b, foo() > > Make use of that foo is being called lazily. > > $ python -m cProfile runHarness.py en-ueb-g2-dictionary_harness.txt > ... > > Ran 99299 tests (99.26% success), with 735 failures and 0 errors. > Before refactor: > 16618186 function calls (16616268 primitive calls) in 22.915 seconds > After refactor: > 16127571 function calls (16125653 primitive calls) in 21.783 seconds > > > Commit: 96befd9354fdbf7770fdacea0c71475be6d85551 > > https://github.com/liblouis/liblouis/commit/96befd9354fdbf7770fdacea0c71475be6d85551 > Author: Mesar Hameed <mesar.hameed@xxxxxxxxx> > Date: 2014-09-06 (Sat, 06 Sep 2014) > > Changed paths: > M tests/harness/runHarness.py > > Log Message: > ----------- > tests/harness/runHarness.py: variable renaming for readibility. > > > Commit: 1a28cd0cf5add8885036e734da5ca7caa8d0475c > > https://github.com/liblouis/liblouis/commit/1a28cd0cf5add8885036e734da5ca7caa8d0475c > Author: Mesar Hameed <mesar.hameed@xxxxxxxxx> > Date: 2014-09-06 (Sat, 06 Sep 2014) > > Changed paths: > M tests/harness/runHarness.py > > Log Message: > ----------- > tests/harness/runHarness.py: Provide compact form of test failures. > > See: > http://liblouis.org/todo/runharness_should_provide_option_for_Condensed_output/ > > > Compare: > https://github.com/liblouis/liblouis/compare/553bdb51b339^...1a28cd0cf5ad
Attachment:
signature.asc
Description: Digital signature
