Re: [i3] Buggy conditional test?

  • From: Alexander Berntsen <alexander@xxxxxxxxxx>
  • To: i3-discuss@xxxxxxxxxxxxx
  • Date: Thu, 30 Jan 2014 13:50:53 +0100

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 30/01/14 13:26, Mateusz Poszwa wrote:

IMHO, that would be inconsistent. I'd say either the former or „ if
(con->window != NULL && con->window->name != NULL) ”
Right. I misread it.

I find it less readable, so I vote for leaving it as it is now. Too
much purism may be harmful. ;-)
I would be just as happy to remove all the != NULLs as adding them,
even if I prefer explicit checking.

Regards,
an advocate of strongly typed languages
- --
Alexander
alexander@xxxxxxxxxx
http://plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iF4EAREIAAYFAlLqSq0ACgkQRtClrXBQc7VnpgD/QAt620WGU6HzcOKhPSh+fTDE
mYRiriTlFEWagqOcwZoA/2HZle1u33jMpR87nhbctmUH1VanwB68RWMNRG41dANF
=/79A
-----END PGP SIGNATURE-----

Other related posts: