[haiku-development] Re: gcc4 build broken in headers/private/userlandfs/shared/HashMap.h

  • From: scott mc <scottmc2@xxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Fri, 20 Mar 2009 07:43:04 -0700

On Thu, Mar 19, 2009 at 10:36 AM, Joseph Prostko
<joe.prostko+haiku@xxxxxxxxx> wrote:
> On Thu, Mar 19, 2009 at 12:43 PM, Urias McCullough
> <umccullough@xxxxxxxxx> wrote:
>> On Thu, Mar 19, 2009 at 4:32 AM, Marcus Jacob <rossi@xxxxxxxxxxxxxxx> wrote:
>>> My usage is to currently use this option, as I have a dedicated build
>>> machine, which toasts a new image every day and by using this option all new
>>> packages are automagically part of the build, without constant maintanance
>>> of the build configuration scripts ;-)
>>
>> I still don't get what you're asking for either :)
>>
>> HAIKU_ADD_ALL_OPTIONAL_PACKAGES=1 does nothing different than just
>> installing all optional packages at build time, so if you're arguing
>> for keeping it because you believe it's solving some problem that
>> can't easily be solved otherwise, I think there's a miscommunication
>> here.
>>
>
> I think that he means it is a lot easier for him to write in his
> ReleaseBuildProfile
>
> HAIKU_ADD_ALL_OPTIONAL_PACKAGES = 1 ;
>
> than something like:
>
> AddOptionalHaikuImagePackages APR APR-util Beam BeBook BeHappy BePDF
> Bluetooth CVS Development Firefox LibLayout Links NetSurf OpenSound
> OpenSSH OpenSSL P7zip Pe Perl Subversion Tar UserlandFS Vision VLC
> Welcome WonderBrush Yasm libMicro PosixTestSuite ;
>
> HAIKU_ADD_ALL_OPTIONAL_PACKAGES also handles any updated packages,
> such as the newly added UserlandFS, which could be missed unless some
> kind of script/parser was written to peek into OptionalPackages and
> OptionalTestPackages, and then update ReleaseBuildProfile or the like
> accordingly to make sure EVERY package is added.
>
> That said, my personal opinion on the matter is to just add every
> package manually that is needed, mostly given the incompatibilities
> (OSS/HDA and BeZilla/Netsurf, for example) that arise when all
> packages are added.
>
> I see that HAIKU_ADD_ALL_OPTIONAL_PACKAGES has been removed as of
> r29608 anyways, so I suppose this is all kind of moot at this point.
>
> - joe
>
>

Perhaps add in the opposite functionality with something like
HAIKU_ADD_ALL_OPTIONAL_PACKAGES_EXCEPT
That way you could just list the packages you don't want installed,
which would likely be a smaller list, and would also then pick up any
newly added packages.
-scottmc

Other related posts: