[haiku-development] Re: Vote for commit access for Jonathan Schiefer / js / midar
- From: PulkoMandy <pulkomandy@xxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Wed, 29 Jan 2014 14:21:29 +0100
Hi,
The patches provided, even if they are still small, show good
understanding of C++ and coding style compliance. Moreover, Jonathan
has took the time to discuss issues on IRC and solve them.
He still has to learn more about the Jam stuff, but many of the devs
are not really up to speed with that anyway.
At this point, it looks like things would be simpler if he could make
changes directly to the git tree instead of wasting time with patch
review.
So, I'm now going to vote +1 for commit access.
2014-01-12, Jonathan Schleifer <js-haiku-development@xxxxxxxxxxx>:
> Am 10.01.2014 um 21:14 schrieb Jonathan Schleifer
> <js-haiku-development@xxxxxxxxxxx>:
>
>> Am 17.12.2013 um 19:16 schrieb Jonathan Schleifer
>> <js-haiku-development@xxxxxxxxxxx>:
>>
>>> Am 17.12.2013 um 08:03 schrieb Adrien Destugues <pulkomandy@xxxxxxxxx>:
>>>
>>>> Since we still want him to show us he's able to fully
>>>> comply with the guidelines, I'd rather review a patchset with those
>>>> fixes,
>>>> split in several smaller commits, for example each fixing a different
>>>> issue
>>>> with non-standard C++.
>>>
>>> And here would be another patch set ;)
>>>
>>> https://dev.haiku-os.org/attachment/ticket/10325/
>>
>> Here is yet another patch set to review:
>> https://dev.haiku-os.org/ticket/10396
>>
>> This makes the Haiku userland compile and work with Clang.
>
> And again another patch set to review:
> https://dev.haiku-os.org/ticket/10402
>
> This makes all of Haiku compile and work with Clang.
>
> Is this enough for a decision or are more patches needed? ;)
>
> --
> Jonathan
>
--
Adrien Destugues / PulkoMandy
http://pulkomandy.tk
Other related posts:
