Hi, Am 17.12.2013 08:33, schrieb Alexander von Gluck IV:
On Dec 17, 2013 1:03 AM, Adrien Destugues <pulkomandy@xxxxxxxxx> wrote:On 2013-12-17 at 04:49:51 [+0100], Alexander von Gluck IV <kallisti5@xxxxxxxxxxx> wrote:Due to the lack of patches, i'd like him to write a quick c++ hello world application where the hello world string is stored in the class in a character array and the function to printf hello world is triggered by a class function. This quick exercise should be a good double check of his haiku style knowledge. (Unless someone has a few haiku patches we can refer to)Please, let's not request more useless work (both on his side and ours) to write and review an hello world program.Works for me. I just wanted a little more substance before fully giving a +1 (which I feel is what most others were thinking)
I really hope that noone else was thinking along the same lines as you. Sorry, but I find your idea rather silly.
First of all, I hope anyone who reads this realizes that no single Haiku developer has capacity to speak for the project as a whole. Except when expressing what I just said. :-P
Second, you don't get commit access for demonstrating you know how to read and write a little hello world code.
You get commit access when you (off the top of my head): * write useful stuff, * show the urge to write elegant, clean code, * demonstrate ability to communicate, i.e. you show you are a nice person,* and lastly, by not annoying others for not following the coding guide lines, wasting everybodies time.
All of these items are important, not just the last. In any decent project, code is not accepted when it just adds something useful. It needs to add it in an elegant way, at the right place, and it should improve the overall code style accordance, not degrade it. (Of course nothing is ever perfect, but it needs to pass some threshold.) I really don't understand why people even submit patches when they don't follow the style. That is like the simplest thing to do out of the above list. In WebKit, you have a green light for style conformance on your patch. Devs won't even look at it, before the light is green. We don't have that, so obviously it gets pointed out if necessary, but that is just one aspect of getting a patch in.
All that being said, I don't know what of it even applies to Jonathan. Which is why I proposed the people who have actually reviewed his patches at the time should speak up.
Best regards, -Stephan
