[haiku-development] Re: Vote for commit access for Jonathan Schiefer / js / midar
- From: Adrien Destugues <pulkomandy@xxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Tue, 17 Dec 2013 08:03:22 +0100
On 2013-12-17 at 04:49:51 [+0100], Alexander von Gluck IV
<kallisti5@xxxxxxxxxxx> wrote:
> As js has been in irc for quite some time, and he does quite a bit of
> development in other projects I'm willing to nominate him for access under
> one small condition.
>
> Due to the lack of patches, i'd like him to write a quick c++ hello world
> application where the hello world string is stored in the class in a
> character array and the function to printf hello world is triggered by a
> class function.
>
> This quick exercise should be a good double check of his haiku style
> knowledge. (Unless someone has a few haiku patches we can refer to)
Please, let's not request more useless work (both on his side and ours) to
write and review an hello world program. There are quite a lot of real tasks
to be done and useful patches to be written.
Jonathan has already worked on those clang support patches, and I think we
should merge that. Since we still want him to show us he's able to fully
comply with the guidelines, I'd rather review a patchset with those fixes,
split in several smaller commits, for example each fixing a different issue
with non-standard C++.
Small patches will pass our review more easily and may be applied separately.
Moreover, applying the patches that fix obvious or more subtle C++ issues
(gccisms and the like) should go without any problem. I suspect the build
system hacks to get clang running may need a bit more work, but that's a
good time to learn Jam :)
With the final version of the patches reviewed and merged, we will have more
sample data for starting the commit access decision.
--
Adrien.
Other related posts:
