[haiku-development] Re: Pairs

  • From: Michael Pfeiffer <michael.w.pfeiffer@xxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Fri, 25 Apr 2008 07:54:29 +0200


Am 25.04.2008 um 07:50 schrieb Michael Pfeiffer:


Am 25.04.2008 um 00:17 schrieb Stephan Assmus:


Michael Pfeiffer wrote:
BTW who has added the delete statement and the comment in
PairsWindow::MessageReceived()?

  delete fPairComparing;
// message of message runner might not have arrived // yet, so it
      is deleted here to prevent any leaking // just in case

When that code path is reached it can be asserted that fPairComparing is
always NULL.

I did, and also added the comment. I might be missing something, but why is it not possible to click onto another button quickly enough, before the
message from the old message runner arrives?

This code is only reached if fIsPairsActive is true.
With fIsPairsActive iff fPairComparing != NULL

I guess I got this wrong. fIsPairsActive is true iff fPairComparing is NULL.

Other related posts: