[haiku-commits] Re: haiku: hrev46304 - src/kits/interface
- From: John Scipione <jscipione@xxxxxxxxx>
- To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
- Date: Mon, 4 Nov 2013 17:31:29 -0500
On Mon, Nov 4, 2013 at 5:09 PM, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> On 11/04/2013 10:45 PM, John Scipione wrote:
>> On Mon, Nov 4, 2013 at 4:25 PM, Ingo Weinhold <ingo_weinhold@xxxxxx>
>> wrote:
>>> On 11/02/2013 07:26 PM, Axel Dörfler wrote:
>>>> Am 01/11/2013 15:32, schrieb Ingo Weinhold:
>>>>> BTW, ShowImage supports horizontal scrolling via Command and zooming
>>>>> via
>>>>> Control, which is the wrong way around, I'd say.
>>>
>>> On Linux and Windows the Control key is used indeed. On Haiku when
>>> switching
>>> the command modifier to Linux/Windows mode, ShowImage uses the Alt key,
>>> though. This seems wrong IMO. Why do I have the feeling that on MacOS
>>> it's
>>> probably Control as well, so that this is another thing that won't be
>>> right
>>> for everyone?
>>
>> We have to be very careful here, when copying from Windows or Linux
>> keep in mind that that the ctrl key is functionally equivalent to our
>> B_COMMAND_KEY which is typically mapped to Alt, so, if your intent is
>> to create something functionally equivalent then zoom should use
>> command and NOT control.
>
> That's exactly what I'm saying. ShowImage implements it the wrong way, as it
> currently uses B_COMMAND_KEY for horizontal scrolling and B_CONTROL_KEY for
> zooming.
Yup, I'm agreeing with you in my own way.
>> Well, this discussion has shown that it is impossible to achieve
>> external consistency here, so, we should strive only for internal
>> consistency ignoring what other OSs do.
>
> I disagree and you're contradicting what you said two paragraphs above wrt
> to the zoom functionality (with which I agree). Internal consistency is
> certainly the main goal, but that doesn't mean that we should ignore other
> systems completely.
Well, external consistency should be strived for above all, but, there
doesn't seem to be any single external consistency to follow. That
being said, shift for fast scrolling, control for horizontal
scrolling, command for zooming seems pretty good to me.
So, we should switch horizontal scrolling to control and zooming to
command in ShowImage to match WebPositive, that way internal
consistency will be reached while external consistency is payed lip
service.
Other related posts:
