[haiku-commits] Re: Terminal broken
- From: François Revol <revol@xxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 17 Aug 2010 16:44:19 +0200
Le 17 août 2010 à 16:25, Stefano Ceccherini a écrit :
> 2010/8/17 Stephan Assmus <superstippi@xxxxxx>:
>> Adrien,
>>
>> I've asked this a few times before: Can you *please* do more testing before
>> you commit changes? It is not that much work to run a stock Haiku image in
>> qemu to make sure your changes really work. At this moment, there is
>> probably noone besides yourself using a shell other than bash, which means
>> you should test your changes on a default image. When I start the Terminal
>> on the current revision (r38178), I get an alert "Cannot execute command" or
>> similar with the buttons "execute" and "%command", and there is no prompt
>> after pressing either button.
>
> BTW, that means that the "execve()" call at line 534 in Shell.cpp
> fails (and it shouldn't fail), and the code which come after (which is
> supposed to show an alert, then fall back to the default shell)
> doesn't work correctly.
Why are you running the alert command instead of creating a BAlert object
anyway ????
Btw we can throw away the __BEOS__ stuff in there now, it's not been building
anymore for quite some time now.
François.
Other related posts:
