On Tue, Aug 17, 2010 at 12:09:16PM +0200, Stephan Assmus wrote:
Adrien,
I've asked this a few times before: Can you *please* do more testing
before you commit changes? It is not that much work to run a stock
Haiku image in qemu to make sure your changes really work. At this
moment, there is probably noone besides yourself using a shell other
than bash, which means you should test your changes on a default
image. When I start the Terminal on the current revision (r38178), I
get an alert "Cannot execute command" or similar with the buttons
"execute" and "%command", and there is no prompt after pressing
either button. I would really like to get some work done, and after
Axels latest commits, I was looking forward to a stable networking,
now I need to revert your recent Terminal changes before I can
start. I know you are not the only one introducing regressions, it
can happen, and sometimes stuff needs to be checked in, so it gets
some exposure, but what annoys me is the "unnecessary" breakage,
stuff that could have been easily tested. Hope you don't take it the
wrong way, maybe I am just annoyed that Haiku has become so unfit
for getting work done recently.
The change was tested and works fine for me (just tested again to be
sure). I'm still running bash in my main image, only using mksh for tests.
I may have missed something, but I did test before committing.
