[haiku-commits] Re: BRANCH looncraz-github.setviewuicolor [8c0d56c205c7] in src: apps/haikudepot/ui servers/app kits/interface apps/haikudepot/ui_generic kits/shared
- From: looncraz <looncraz@xxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 2 Oct 2015 14:33:44 -0500
On 10/2/2015 12:59, Paweł Dziepak wrote:
Hi,
On 2 October 2015 at 17:32, Stephan Aßmus <superstippi@xxxxxx
<mailto:superstippi@xxxxxx>> wrote:
Reviewing the end result – yes. End result in a form of a single large
patch – no.
I agree that it is just a waste of reviewer's time trying to read
something like:
commit 1: my change
commit 2: fix build
commit 3: fix bug introduced in commit 1
Patches like that should be squashed into a single one before the
final merge, as they only pollute history and confuse readers.
My commits are rather jumbled due to the nature of the changes involved
(a minor change in View may result in a reordering of events in apps
using the layout kit, for example), the fact that many of my commits
include fixes for problems arising from earlier ones, and the fact that
I think and type at about 2,000kph (a blessing and a curse, especially
when you notice you typed the last sentence entirely backwards and have
to unjumble it...twice).
The only real way to look at it is in its final revision. That said, I
could literally trash the commit history all the way back to master,
then add the modified files in groups, but I will definitely mess up in
that process at some point, since the changes are so often interdependent.
This will be a rather large commit, no way around that, so many changes
being involved, but almost every change is simple - and many are
intertwined and very repetitive. As I moved through the applications I
found more use cases that required more changes to the interface kit to
ensure that any use color settings would be functional. I think I have
now mostly achieved that, with only a few apps in the entire system
using manual colors - and then only when it makes sense.
The vast majority of my changes are just setting the view color and
dealing with the fact that views with layouts now have the
B_PANEL_BACKGROUND_COLOR as its default color.
I also fixed a couple of TODOs, introduced link colors, and a few minor
things that I knew no one would complain about.
The Tracker InfoWindow, for example, is the same thing it was, just
scaled up. In fact, other than mouse over effects for the link text, it
is the same thing it was, just scales with the font size ;-)
I feel that the code will require few changes to be acceptable. And I
don't foresee many instances of unintended consequences that can't be
easily remedied.
--The loon
P.S. I tend to write long comments as well :p
Other related posts:
