[haiku-commits] Re: BRANCH looncraz-github.setviewuicolor [8c0d56c205c7] in src: apps/haikudepot/ui servers/app kits/interface apps/haikudepot/ui_generic kits/shared

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 2 Oct 2015 18:32:16 +0200

Hi,

Am 02.10.2015 um 18:07 schrieb looncraz:

On 10/2/2015 10:45, Urias McCullough wrote:
On Fri, Oct 2, 2015 at 8:44 AM, looncraz <looncraz@xxxxxxxxxxx> wrote:
Not sure why, though, when this is all done, a squashed commit makes
for the
best way to merge the code into Haiku, provided it is accepted.
That seems like a subjective opinion.

Many devs (myself for one) may prefer to retain the individual commit
history as it more accurately shows the thought process and
incremental work that went into development of a feature.

- Urias

Funny, I've always found it to be damaging when trying to cleanly merge
new code.

But I'll submit however y'all please. I'm about as opinionated as a
rock when it comes to how people run their own projects :p

I for one would prefer to review a single patch against head, i.e. the end result. Especially since I couldn't review the commits so far in depth and I don't want to make comments on something that got changed anyway. Whether it makes more sense to commit as small commits or as one squash commit, I have not much of an opinion on.

Best regards,
-Stephan



Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 10-2015