[haiku-commits] Re: BRANCH looncraz-github.setviewuicolor [8c0d56c205c7] in src: apps/haikudepot/ui servers/app kits/interface apps/haikudepot/ui_generic kits/shared

  • From: looncraz <looncraz@xxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 2 Oct 2015 10:44:08 -0500

On 10/2/2015 02:32, Axel Dörfler wrote:


+ if (flags & B_SUPPORTS_LAYOUT) {

That would be:
if ((flags & B_SUPPORTS_LAYOUT) != 0) {

BTW: since you separate the commit message into several components already, and have a quite detailed list, could you please divide the commits into several smaller ones?

Bye,
Axel.



It's done both ways in View.cpp. I'll change it, though.

I'll send my future commits in tiny little chunks :p

Not sure why, though, when this is all done, a squashed commit makes for the best way to merge the code into Haiku, provided it is accepted.

--The loon

Other related posts: