[haiku-bugs] Re: [Haiku] #7445: app_server DecorManager + DecorInfo patch

  • From: "looncraz" <trac@xxxxxxxxxxxx>
  • Date: Thu, 19 May 2011 01:34:44 -0000

#7445: app_server DecorManager + DecorInfo patch
----------------------------------+-------------------------------------
   Reporter:  looncraz            |      Owner:  axeld
       Type:  enhancement         |     Status:  new
   Priority:  normal              |  Milestone:  Unscheduled
  Component:  Servers/app_server  |    Version:  R1/Development
 Resolution:                      |   Keywords:  DecorManager, decorator
 Blocked By:                      |   Blocking:
Has a Patch:  1                   |   Platform:  All
----------------------------------+-------------------------------------

Comment (by looncraz):

 I have mode the changes as follows:

 Strictly enforced the 80 char line limit where it failed previously.

 Found several location where the opening stanza was on the line instead of
 on the same line of a conditional statement.

 Found a single place in all the code where variables were allocated at the
 opening of a function.

 Corrected an odd issue with a multi-line printf statement ( thanks
 stargatefan! )

 Changed the name of Stack & Tile to Stack and Tile.

 In addition to those changes I propose related, but not integral, changes
 to the names of the generated decorators:

 WinDecorator = windows95
 MacDecorator = macos9
 SATDecorator = stackandtile
 BeDecorator = beos

 If this code is accepted and merged upstream I will create a new
 Appearance preflet using the code and implement either a static preview or
 a generated preview depending on popular input.

 Thanks!

 --The loon

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/7445#comment:18>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: