[haiku-bugs] Re: [Haiku] #7445: app_server DecorManager + DecorInfo patch
- From: "stargatefan" <trac@xxxxxxxxxxxx>
- Date: Wed, 18 May 2011 16:17:51 -0000
#7445: app_server DecorManager + DecorInfo patch
----------------------------------+-------------------------------------
Reporter: looncraz | Owner: axeld
Type: enhancement | Status: new
Priority: normal | Milestone: Unscheduled
Component: Servers/app_server | Version: R1/Development
Resolution: | Keywords: DecorManager, decorator
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
----------------------------------+-------------------------------------
Comment (by stargatefan):
Replying to [comment:12 stippi]:
> Could you please point out where there have been list lookups replaced
that are performance relevant to make the "UI noticeably snappier"? That
statement looks really dubious to me. I understand the desire to get
patches in, it contains hard work, but nobody needs to resort to such
claims (but I'll apologize when you can indeed point out the performance
improvements in the code). The real reason that I have not applied this
patch yet is not that I need more incentive to do so, but because there
are still a whole lot of coding style violations. Before applying the
patch, I intend to fix them, and it's just a daunting work, I have no time
and I just don't understand why I have to do it and not looncraz. I also
pointed out that the preview solution is pretty hacky, but I understand
that the motivation is low to code a proper solution (which would be to
let Decorators render into a bitmap and show the user a preview of all
decorators side by side before he even selects any other).
I noticed that the patch made the UI snappier and a bit more fluid. I
didn't go in expecting anything in that regard I was looking for
regressions etc that could be show stoppers.but it was noticeable enough
that I noticed it, I also saw a .5% drop of cpu resource at idle use on
the anyboot with this patch over the current revision nightlys. Yes I
double checked.
It was fiarly noticeable on the anyboot cd. There is a bug with enabling
stack and tile. It simply won't enable from terminal commands. and I think
its the naming scheme or some inconsistency, I will take a look.
The typo in the patch is decorinfo.cpp line 276 IIRC.
Configuration preflet would be much appreciated from me and many others
I assume. I have a thing againt using terminal to do basic stuff in the
OS. I always remeber that if my wife can't click on it, she can't do it.
One thing I did notice Stippi. What ever the total of these changes
does, when QT cuases deskbar crashs, and it sometimes does, instead of the
desktop deskbar locking up randomly, it is more easily recorvered.
Now if thats a byproduct of this patch or other fixs ?? But I did notice
that deskbar seems to more easily recovered with this patch.
That would take a good bit of chasing down to determine
BTW these are my observations, they are not tested facts. But you can
always test for yourself and see what that gets ya.I think you are vastly
more knowledgable then myself and would be able to test for this.
--
Ticket URL: <http://dev.haiku-os.org/ticket/7445#comment:14>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
