[dokuwiki] Re: [PATCH] refactored media form to use new form class
- From: Michael Klier <chi@xxxxxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Fri, 5 Oct 2007 21:27:18 +0200
TNHarris wrote:
>
> On Mon, 1 Oct 2007 23:55:44 +0200, "Michael Klier" <chi@xxxxxxxxxxx>
> said:
> I've considered, briefly, the advantages of combining extra 'class'
> attributes into one, but I couldn't think of case where it would really
> be better. Not to mention that it would be more difficult to handle when
> a plugin must overwrite the default value.
>
> So default class specification should be moved to the factory function
> (form_make*) then merged with the argument attributes.
Yes, how would you go about that? Maybe you could patch the form code
and I modify my patches when it`s merged into the main repo and then
send them to the list again?
> > Therefore it was necessary to introduce a new function in the form class
> > to be able to specify the forms' enctype. Rather than putting this into
> > the constructor I decided it would eventually be better to have a
> > separate function named: setEnctype($enctype).
> >
>
> I would argue that the encoding type is a property of the form, and not
> a child. It should probably also be read-write. Just like action,
> method, and id.
It is read/write like action and id - setEnctype() sets the class var
$_enctype (defaults to false) - or maybe I dont understand correctly
what you mean by read/write. I thought a dedicated method would
eventually be a good thing. I thought about adding the enctype setting
to the constructor but I wasn`t sure about the best order of the passed
values -(I have to say that I am not the super experienced OOP guy
though).
Best Regards,
Chi
--
Michael Klier
mail: chi@xxxxxxxxxxx
www: http://www.chimeric.de
icq: 206179334
jabber: chi@xxxxxxxxxxxxxxxxxx
key: http://downloads.chimeric.de/chi.asc
key-id: 0x8308F551
Other related posts:
