[dokuwiki] Re: [PATCH] refactored media form to use new form class
- From: Michael Klier <chi@xxxxxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Tue, 2 Oct 2007 13:07:36 +0200
Chris Smith wrote:
> Michael Klier wrote:
> > I have a question also: while digging to the code of inc/form.php I
> > noticed that there`re lots of places where class="edit" is hardcoded to
> > the elements with a follow-up call to buildAttributes(), so if someone
> > would pass an extra attribute class to that call you`ll end up with to
> > class attributes (I don`t know if this is allowed by the HTML specs but
> > to me it feels wrong)
> >
> Multiple classes in one class attribute (e.g. class="edit required
> error") is fine, two or more class attributes in one tag (e.g.
> class="edit" class="required") is not valid.
Ok - as I thought. I think that should be changed somehow then, because
if left that way you wont be able to assign other CSS classes to the
form elements without breaking XHTML compliance. I know that`s this is
not much of a problem for the DW forms, but I also think we should avoid
possible compliance breakage directly in the form class itself.
@Tom as the author of the form class, what do you think about it?
Best Regards,
Chi
--
Michael Klier
mail: chi@xxxxxxxxxxx
www: http://www.chimeric.de
icq: 206179334
jabber: chi@xxxxxxxxxxxxxxxxxx
key: http://downloads.chimeric.de/chi.asc
key-id: 0x8308F551
Other related posts:
