[dokuwiki] Re: [PATCH] refactored media form to use new form class
- From: Chris Smith <chris@xxxxxxxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Sat, 06 Oct 2007 01:40:31 +0100
Michael Klier wrote:
> TNHarris wrote:
>
>> On Mon, 1 Oct 2007 23:55:44 +0200, "Michael Klier" <chi@xxxxxxxxxxx>
>> said:
>> I've considered, briefly, the advantages of combining extra 'class'
>> attributes into one, but I couldn't think of case where it would really
>> be better. Not to mention that it would be more difficult to handle when
>> a plugin must overwrite the default value.
>>
>> So default class specification should be moved to the factory function
>> (form_make*) then merged with the argument attributes.
>>
>
> Yes, how would you go about that? Maybe you could patch the form code
> and I modify my patches when it`s merged into the main repo and then
> send them to the list again?
>
>
It isn't (or shouldn't be) more difficult to override a default value
when a plugin adds a second (or subsequent) class to the form. IE6
apart it is possible to specify multiple class values in a single CSS
rule (e.g. #fieldname.required.error). Even in IE6 it is likely the
plugin CSS will be able to specify rules in such a form to take
precedence over the default styles.
I say implement the combining of class values into a single class
attribute and let the plugin authors work out what they can and can not do.
-- Chris
--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist
Other related posts:
