commit/wintenApps: 3 new changesets

  • From: commits-noreply@xxxxxxxxxxxxx
  • To: commits+int+220+6085746285340533186@xxxxxxxxxxxxxxxxxxxxx, nvda-addons-commits@xxxxxxxxxxxxx
  • Date: Fri, 08 Mar 2019 19:07:22 +0000 (UTC)

3 new commits in wintenApps:

https://bitbucket.org/nvdaaddonteam/wintenapps/commits/157d0ec475d8/
Changeset:   157d0ec475d8
Branch:      None
User:        josephsl
Date:        2019-03-08 16:55:15+00:00
Summary:     WinTenObjs: remove unused imports, move wx import to virtual 
desktop announcement routine.

Affected #:  1 file

diff --git a/addon/globalPlugins/wintenObjs/__init__.py 
b/addon/globalPlugins/wintenObjs/__init__.py
index 6bea3ad..7e48f3f 100755
--- a/addon/globalPlugins/wintenObjs/__init__.py
+++ b/addon/globalPlugins/wintenObjs/__init__.py
@@ -10,8 +10,6 @@ from NVDAObjects.UIA import UIA, SearchField, Dialog, 
ComboBoxWithoutValuePatter
 from NVDAObjects.behaviors import EditableTextWithSuggestions, ToolTip
 import api
 import nvwave
-import gui
-import wx
 import config
 import queueHandler
 import globalVars
@@ -214,7 +212,7 @@ class GlobalPlugin(globalPluginHandler.GlobalPlugin):
                # NVDA Core issue 5641: try catching virtual desktop switch 
event, which will result in name change for the desktop object.
                # To be taken care of by NVDA Core, and for older releases, let 
the add-on handle it for a time.
                if obj.windowClassName == "#32769":
-                       import eventHandler
+                       import wx, eventHandler
                        if not hasattr(eventHandler, 
"handlePossibleDesktopNameChange"):
                                wx.CallLater(500, ui.message, obj.name)
                self.uiaDebugLogging(obj, "nameChange")


https://bitbucket.org/nvdaaddonteam/wintenapps/commits/8e117de39ae9/
Changeset:   8e117de39ae9
Branch:      None
User:        josephsl
Date:        2019-03-08 19:07:01+00:00
Summary:     Mail: catch COM error not caught by NVDA Core.

NVDA Core issue 9341 (and potentially 9333): when looking for parent of Word 
document tree interceptor object, COM error is thrown, causing NVDA to go 
silent or play error tones continuously after closing Mail app. Thus catch this 
error from the add-on.

Affected #:  1 file

diff --git a/addon/appModules/hxoutlook.py b/addon/appModules/hxoutlook.py
index 4f3f84c..ed90038 100644
--- a/addon/appModules/hxoutlook.py
+++ b/addon/appModules/hxoutlook.py
@@ -7,6 +7,7 @@
 """An appModule for the Windows 10 Mail app"""
 
 from nvdaBuiltin.appModules.hxoutlook import *
+from comtypes import COMError
 import api
 from NVDAObjects.UIA import UIA
 from NVDAObjects.behaviors import RowWithFakeNavigation
@@ -31,6 +32,26 @@ class MailItemRow(RowWithFakeNavigation, UIA):
                # Therefore report that this is not supported yet.
                ui.message(_("Cannot move between rows"))
 
+# NVDA Core issue 9341: temporary workaround for COM error exception found in 
NVDA.
+class MailWordDocument(WordDocument):
+
+       treeInterceptorClass=MailWordDocumentTreeInterceptor
+       def _get_shouldCreateTreeInterceptor(self):
+               # Locate the Reading pane in the ancestors
+               
condition=UIAHandler.handler.clientObject.createPropertyCondition(UIAHandler.UIA_ClassNamePropertyId,"ReadingPaneModern")
+               
walker=UIAHandler.handler.clientObject.createTreeWalker(condition)
+               try:
+                       parent=walker.NormalizeElement(self.UIAElement)
+               except COMError:
+                       parent=None
+               if not parent:
+                       return False
+               # If we can find the message headers, then it is read-only and 
therefore needs browseMode
+               # An editable document contains draft headers instead
+               
condition=UIAHandler.handler.clientObject.createPropertyCondition(UIAHandler.UIA_AutomationIdPropertyId,"MessageHeader")
+               
header=parent.findFirst(UIAHandler.TreeScope_Descendants,condition)
+               return bool(header)
+
 
 class AppModule(AppModule):
 


https://bitbucket.org/nvdaaddonteam/wintenapps/commits/eb500a8dda2f/
Changeset:   eb500a8dda2f
Branch:      stable
User:        josephsl
Date:        2019-03-08 19:07:09+00:00
Summary:     Readme entry on Mail app closing bug fix

Affected #:  1 file

diff --git a/readme.md b/readme.md
index e6820c5..f6bf201 100755
--- a/readme.md
+++ b/readme.md
@@ -80,6 +80,7 @@ For a list of changes made between each add-on releases, 
refer to [changelogs fo
 
 * When reviewing items in messages list, you can now use table navigation 
commands to review message headers. Note that navigating between rows 
(messages) is not supported.
 * When writing a message, appearance of at mention suggestions are indicated 
by sounds.
+* NVDA will no longer do anything or play error tones after closing this app.
 
 ## Maps

Repository URL: https://bitbucket.org/nvdaaddonteam/wintenapps/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.

Other related posts: