[haiku-development] Re: Rant about quality and testing
- From: Oliver Tappe <zooey@xxxxxxxxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Sun, 27 Feb 2011 15:12:33 +0100
Hi Stephan,
from my POV, this rant is quite welcome ;-)
I basically spent all day yesterday trying to replace the hardcoded paths
used by existing code with corresponding find_directory() invocations.
Irritatingly, I found several hardcoded paths in pretty new code, too.
On 2011-02-27 at 14:23:04 [+0100], Stephan Assmus <superstippi@xxxxxx> wrote:
>
[ ... ]
> Today it went something like this: I wanted to look at a problem in
> AboutSystem with the building of the translated Haiku license string.
> Basically, the translated name for the license is inserted broken. Now,
> this means someone didn't test their changes. Either it was a
> contributor of a patch. Then the lack of testing began there, and
> continued at the committer of the patch who didn't test it properly
> either and just trusted the contributor. When I wanted to log the bug
> from WebPositive in Haiku, I could not log into Trac. "Protocol not
> supported". HTTPS is not supported in WebPositive anymore, I suspect
> because of the very recent update of libcurl. Again, something was
> replaced that worked perfectly fine before, without the necessary
> testing. WebPositive is a tool that I suspect many are using when they
> use Haiku. So extra care has to be taken when changing it or components
> that it depends on. Especially so when you make a commit for no obvious
> benefit. Then I wanted to look at the AboutSystem problem myself, but
> now Pe does not open, because there is a problem with a missing libpcre.
> Again, some package was changed without proper testing prior to the
> commit. That just did for today and now I am writing this mail.
In order to lessen the problems related to packaging, I think we should
maintain at least two different package repositories: haiku and
haiku-testing. Freshly built packages would be added to the haiku-testing
and only after they've passed a (yet to be defined) testing process, will
they be added to haiku-core.
While it doesn't make sense to (more or less) blindly add new packages to
our repository, it's still nice to be following the head of development in
the testing repository in order to see problems of current packages as soon
as possible.
Of course, this doesn't help at all with the problems you mentioned
concerning the quality of our own code.
cheers,
Oliver
Other related posts:
