On Mon, May 26, 2008 at 3:45 PM, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote: > > On 2008-05-27 at 00:22:11 [+0200], Andreas Färber <andreas.faerber@xxxxxx> > wrote: >> >> Am 27.05.2008 um 00:10 schrieb Ingo Weinhold: >> >> > On 2008-05-26 at 23:00:26 [+0200], Andreas Färber <andreas.faerber@xxxxxx >> > > >> > wrote: >> >> libiconv [...] [Ingo, if you're reading this, please have a look at >> >> config.sub, >> >> doesn't look correct to me?]. >> > >> > Not sure what you mean. What do you think is wrong with config.sub? >> >> In one of the files in the libiconv patch (I thought it was in >> config.sub) there was a list of operating system expressions, such >> as ... | -beos* | ... whereas Haiku was listed as ... | -beos* | >> haiku* | ... without the dash. No idea if it has any significance but >> it caught my eye that it was the only one without dash. > > Yep, that looks wrong. If that is the case block I think it is, the Haiku > case is already listed, BTW (several lines later). > > Anyway, I'd recommend not to edit generated files (like config.guess, > config.sub, ltmain.sh,...) in the first place -- use the auto tools to > replace them instead -- and also not to include them in patches. Rather > document how to run which of the auto tools to replace them. > > CU, Ingo > I've updated the diff file to remove config.sub. Turns out that was the only edit I have made to config.sub and as Ingo points out it was there, just 2 or 3 lines further down in the code. I thought it was strange that I saw haiku is 2 or 3 other spots in that config.sub but not in that section (it was there but bad eyes here). Anyways seems strange that some of these tarballs have haiku in some files but not others. Instead of editing config.guess I'll be copying the one that comes with a new Haiku install and putting it over any config.guess that comes with a package prior to working on it. I'm trying to get each one to build as a native haiku build, rather than trying --build=i586-beos. That way if/when the beport program is working it will be able to follow the bep file script and just work (in theory?). I'll watch my PortLog updates and leave prior work in place, perhaps striking out parts that are no longer needed? -scottmc -- BePorts homepage - http://tools.assembla.com/BePorts List archives: //www.freelists.org/archives/beports Administrative contact: brecht@xxxxxxxxxxx