On 24/10/14 21:50, Will Godfrey wrote:
On Fri, 24 Oct 2014 10:10:18 +0200
Kristian Amlie <kristian@xxxxxxxxxx> wrote:
----------
diff --git a/src/Misc/Config.h b/src/Misc/Config.h
index 9437475..d54810c 100644
--- a/src/Misc/Config.h
+++ b/src/Misc/Config.h
@@ -51,7 +51,7 @@ class Config : public MiscFuncs
void StartupReport(void);
void Announce(void);
void Usage(void);
- void Log(string msg, bool tostderr = false);
+ void Log(string msg, bool tostdout = true); // was tostderr
void flushLog(void);
void clearBankrootDirlist(void);
void clearPresetsDirlist(void);
----------
This makes everything go to stderr instead. The new argument name,
tostdout, appears to be wrong, since the Log function does in fact write
to stderr, not stdout.
As with everything about Yoshimi, there's a bit more to it :)
I actually reverted that change pretty quickly when I understood the operation
better. However, I then later again set the flag to 'true' so that I could see
all messages in the same terminal window I was launching each build of yoshi
from - not noticing that this killed the console window output.
OTOH, having an in-app console was always a bit weird to me, so I'm not
opposed to removing it and declaring that all messages go to the
terminal instead.
Eventually I think *useful* error messages should appear in a proper gui
window, but the full log should always go to stderr, however as an interim
measure, next time I'm pushing stuff to master, I'll include a compile-time
switch to enable/disable console window reporting.
