When I refactored basically all of the code of seq24, I first ran each
module through astyle. But I've since touched basically every line of
code manually. Gotta have that personal touch!
It pays, of course, to do things in small steps, especially
with sensitive audio/MIDI apps :-D
Anyway, a uniform style pays off in the long run, greatly increasing
the *grokkability* of the code.
-------- Will Godfrey 23:49 Sun 27 Mar --------
If anyone does a git pull they'll think I've done a massive amount of coding
... I wish!
Still not up to par, I decided to just browse around some of the dark corners
of the code where I'd never been before. It was an interesting trip.
There was some of Paul's original code that clearly had never been touched, as
well as some recognisably Cal's. Then a menagerie of styles, many not even
self consistent, never mind the overall style.
... and lots of trailing whitespace.
My text editor is now configured to remove trailing spaces on saving, so that
was the easy one. However, because of all the style variations I didn't trust
the idea of using an automated system on those, so have been going through the
files by hand. It's actually not so hard once you get going - a bit like
painting your house :)
I've almost dome the lot now and it's basically Cal's style - which I've always
liked, right from the first time I looked at the code.
So there you go. The windows still rattle in the wind, and there's a couple of
doors that stick, but it's nice and tidy inside :)
--
Will J Godfrey
http://www.musically.me.uk
Say you have a poem and I have a tune.
Exchange them and we can both have a poem, a tune, and a song.
Yoshimi source code is available from either:
http://sourceforge.net/projects/yoshimi
Or: https://github.com/Yoshimi/yoshimi
Our list archive is at: https://www.freelists.org/archive/yoshimi
To post, email to yoshimi@xxxxxxxxxxxxx
