[tarantool-patches] Re: [PATCH v1 2/2] sql: prevent executing crossengine sql

  • From: Vladislav Shpilevoy <v.shpilevoy@xxxxxxxxxxxxx>
  • To: Kirill Shcherbatov <kshcherbatov@xxxxxxxxxxxxx>, tarantool-patches@xxxxxxxxxxxxx
  • Date: Fri, 27 Jul 2018 11:55:48 +0300

Hi! I do not see your answer. You've just sent empty email with my cite.

On 27/07/2018 10:13, Kirill Shcherbatov wrote:

Thanks for the fixes! I have pushed my own on the branch.
Please, squash.

Sorry, I was wrong about txn != NULL omitting. If we omit it,
then for ephemeral spaces we do not start ro stmt, but commit
it. It is not correct.

Your code works only because commit_ro() is no-op when we
have an active transaction. But it can change in futureThank you for review. 
I've squashed this changes.

Other related posts: