[tarantool-patches] Re: [PATCH v1 2/2] sql: prevent executing crossengine sql

  • From: Vladislav Shpilevoy <v.shpilevoy@xxxxxxxxxxxxx>
  • To: Kirill Shcherbatov <kshcherbatov@xxxxxxxxxxxxx>, tarantool-patches@xxxxxxxxxxxxx
  • Date: Fri, 27 Jul 2018 00:26:57 +0300


Thanks for the fixes! I have pushed my own on the branch.
Please, squash.

Sorry, I was wrong about txn != NULL omitting. If we omit it,
then for ephemeral spaces we do not start ro stmt, but commit
it. It is not correct.

Your code works only because commit_ro() is no-op when we
have an active transaction. But it can change in future.

Other related posts: