Re: Fwd: Re: [PATCH] PCI I/O space
- From: Antti Kantee <pooka@xxxxxx>
- To: rumpkernel-users@xxxxxxxxxxxxx
- Date: Mon, 08 Jun 2015 21:20:42 +0000
On 08/06/15 20:33, Robert Millan wrote:
El 08/06/15 a les 07:53, Antti Kantee ha escrit:
Is that print necessary? "dmesg" will already contain the information
of I/O space being available or not. I'm undecided.
You mean the lack of "I/O space enabled" in this message?
pci0: memory space enabled, rd/line, rd/mult, wr/inv ok
I think those unfamiliar with Rump and/or NetBSD will find the extra
information useful.
Yea, that print.
I'm just worried that your print will look too much like an error when
it is not necessary so. Perhaps there's a way to make the print softer,
something to indicate that some features are missing most likely because
the program is not being run as root or with CAP_SYS_RAWIO. In other
words, treat EPERM as the common case error.
Also, the print and the call doesn't match: pci_init() vs. "iopl failed".
Finally, commenting on the hypercall side of the patch, you should not
return the return value of iopl(), but rather the translated errno.
Other related posts:
