[pisa-src] Re: r1008 - trunk/include

  • From: Thomas Jansen <mithi@xxxxxxxxx>
  • To: pisa-src@xxxxxxxxxxxxx
  • Date: Wed, 30 Sep 2009 17:34:13 +0200

On Wed, Sep 30, 2009 at 05:14:33PM +0200, Diego Biurrun wrote:
> On Wed, Sep 30, 2009 at 05:12:09PM +0200, Thomas Jansen wrote:

> Mixing unrelated changes is not good.

The relation is quite simple: It's MTU-related!

> But mismatches between commit content and log message are supremely evil.
> Please don't do it and please fix the commit message.

Actually, the commit message contains all relevant information in a condensed
form. Two changes, two sentences: MTU tweaking part 2 refers to the MTU
tweaking commit, where you wanted additional documentation. Even bigger buffers
refers to the change in the MAX_PACKET_BUFFER_TUN definition.

Thomas Jansen, "Mithi" --- mithi@xxxxxxxxx
GPG 9D5C682B, feel free to sign or encrypt your mail

Other related posts: