[pisa-src] Re: r1008 - trunk/include
- From: Diego Biurrun <diego@xxxxxxxxxx>
- To: pisa-src@xxxxxxxxxxxxx
- Date: Wed, 30 Sep 2009 18:54:06 +0200
On Wed, Sep 30, 2009 at 05:34:13PM +0200, Thomas Jansen wrote:
> On Wed, Sep 30, 2009 at 05:14:33PM +0200, Diego Biurrun wrote:
> > On Wed, Sep 30, 2009 at 05:12:09PM +0200, Thomas Jansen wrote:
>
> > Mixing unrelated changes is not good.
>
> The relation is quite simple: It's MTU-related!
>
> > But mismatches between commit content and log message are supremely evil.
> > Please don't do it and please fix the commit message.
>
> Actually, the commit message contains all relevant information in a condensed
> form. Two changes, two sentences: MTU tweaking part 2 refers to the MTU
> tweaking commit, where you wanted additional documentation. Even bigger
> buffers
> refers to the change in the MAX_PACKET_BUFFER_TUN definition.
Ummm, for some reason I completely misread your commit. So disregard my
command and please forget that I ever said anything ;)
Diego
Other related posts:
