Hi, I have added licensing and copyright information in the plugin.
Originally I started creating an installTasks for other old add-ons for
which I didn't follow the guidelines, needed for translation workflow
about names, when this list didn't exist. This is to request
incompatible add-on removal.
This installTasks is adapted to every add-on when needed, and so
contributed by people. So I think it's better not to add copyright there.
In the readme, I have indicated that the old ReportSymbol add-on was
developed by the same author.
If no objection is reported, I can release 1.1-dev version tomorrow,
posting it on the add-ons website, to release 1.0 stable version after
my holliday, in September.
Please, feel free to contribute or provide feed-back for improve this
add-on to asian community if needed.
The last commit is at
https://github.com/nvdaaddons/reportSymbols/commit/50530d995c96d2c0fd7079f573a635cd5dc09a91
Cheers.
El 28/07/2016 a las 10:54, Noelia escribió:
Thanks.----------------------------------------------------------------
Comments: I thought about monkey patching a speech function, but I think
it's better to use events as documented in the development guide.
I will provide copyright and license information to post the add-on.
Before contributing add-ons in NVDA, I worked for my own with JAWS
scripts, often without sharing them, just for me, and I'm not used to
provide this kind of information.
But I will do.
Cheers.
El 28/07/2016 a las 10:40, Joseph Lee escribió:
Hi all,
Basic review results for Report Symbols:
· Copyright and licensing: no information given
· Security: pass
· User experience: pass
Comments:
· I thought typed character event only took character, and
didn’t encounter the global plugin form until now.
· Please provide suitable copyright and license header in at
least one of the source files, as without that, we cannot continue
with reviews.
· When entering Korean, add-on setting will not have any
effect due to appearance of composition window (this applies to other
Asian char input scenarios).
I recommend a green light once copyright info/licensing header is given.
Cheers,
Joseph
