Hi, I have done basic review for this:
https://github.com/abdel792/mp3DirectCut
1. License and Copyright (not explicitly mentioned), so applied GNU 2: Pass.
2. Security: Pass (nothing harmful).
3. User experience: Pass (nothing is broken, for instance using monkey
patching.
So it can be posted on the add-ons website.
2. Notes:
2.1. Translation workflow:
a. I recommend to check the pythonSources set in buildVars, where
appModule and other files don't appear.
b. Add comments for translators.
c. You use u'' in translatable messages. This is not used; I suggest to
use just strings, for instance _("Message to translate").
2.2. Code: Possible tips:
a. Don't use .__doc__ in scripts whose gestures shouldn't be changed,
for instance right arrow (which depends on the mp3DirectCut program and
is sent with gesture.send()), so that they don't appear in Input
Gestures dialog with the risk of mangling the add-on.
b. You may want to follow the Contributing guidelines for NVDA regarding
to code style, to ease of review, for instance, don't use underscores to
separate words in function names; use mixed case.
c. Perhaps the code can be simplified and optimized if you use custom
classes and event_valueChange(), if possible, to retrieve information as
selection and others, instead of searching objects and using scripts
from globalcommands.
Thanks.
El 13/07/2016 a las 23:07, Abdel escribió:
Hi Noelia,----------------------------------------------------------------
In fact, the add-on had already been translated into Arabic and Spanish,
but I have removed these two translations for it to undergo basic review.
If you want, I think it can be proposed to the basic review.
If you have any suggestions about the code, they will be welcome.
For nvda-addon team on Github, Joseph has already sent me an invitation,
I thank him very much.
As I see there are still some commits on the nvdaaddonteam of bitbucket,
I would also be interested to be part of this team.
Thanks for all.
Cheers.
-----Message d'origine----- From: Noelia
Sent: Wednesday, July 13, 2016 10:38 PM
To: nvda-addons@xxxxxxxxxxxxx
Subject: [nvda-addons] Re: Ho to be a member on nvdaaddonteam
Yes, please let us know if you want an invitation. personally, I'm
moving my add-ons there, so that if people would like the same, source
and releases can be found all together.
For Abdel, I think your add-on is floating, that is, available for
download but not in the add-ons website, accessible from the add-ons
manager and that has known criteria for posting, that can be considered
a trust place.
So, let us know when your add-on is ready for basic review and we can
post it in the website.
Thanks.
El 13/07/2016 a las 22:06, Joseph Lee escribió:
Hi,----------------------------------------------------------------
Will send an invite.
To others: please let me (josephsl) or Noelia (nvdaes) know if you’d
like to be added to NVDA Add-ons organization on GitHub.
Cheers,
Joseph
*From:*nvda-addons-bounce@xxxxxxxxxxxxx
[mailto:nvda-addons-bounce@xxxxxxxxxxxxx] *On Behalf Of *Abdel
*Sent:* Wednesday, July 13, 2016 1:02 PM
*To:* nvda-addons@xxxxxxxxxxxxx
*Subject:* [nvda-addons] Re: Ho to be a member on nvdaaddonteam
Hi Joseph,
Thank you very much.
I just added the add-on on Github:
https://github.com/abdel792/mp3DirectCut
Can you add me as a member of this team please?
Thanks in advance.
Your suggestions are welcome.
Cheers.
*From:*Joseph Lee <mailto:joseph.lee22590@xxxxxxxxx>
*Sent:*Wednesday, July 13, 2016 8:11 PM
*To:*nvda-addons@xxxxxxxxxxxxx <mailto:nvda-addons@xxxxxxxxxxxxx>
*Subject:*[nvda-addons] Re: Ho to be a member on nvdaaddonteam
Hello,
We’re moving some repos to Github, and we have GitHub equivalent of old
Bitbucket version:
http://github.com/nvdaaddons
Cheers,
Joseph
*From:*nvda-addons-bounce@xxxxxxxxxxxxx
<mailto:nvda-addons-bounce@xxxxxxxxxxxxx>
[mailto:nvda-addons-bounce@xxxxxxxxxxxxx] *On Behalf Of *Abdel
*Sent:* Wednesday, July 13, 2016 11:09 AM
*To:* nvda-addon <nvda-addons@xxxxxxxxxxxxx
<mailto:nvda-addons@xxxxxxxxxxxxx>>
*Subject:* [nvda-addons] Ho to be a member on nvdaaddonteam
Hi everyone,
I just create with the help of some contributors, an add-on for NVDA,
improving the accessibility of the software mp3DirectCut
I would add this add-on in the nvdaaddonteam of bitbucket but I can not
add it because I'm not a member.
I've sent a message to the administrator of nvdaaddonteam, but I did not
get any answer.
There are a few times, I had created with the help of Noelia and Joseph,
an add-on for the day of the week, which was added in the nvdaaddonteam.
https://bitbucket.org/nvdaaddonteam/dayoftheweek
Someone can help me please?
Another question: Is there a team for nvda-addon contributors on github
like on bitbucket?
Thanks in advance.
Best regards.
NVDA add-ons: A list to discuss add-on code enhancements and for
reporting bugs.
Community addons are available from: http://addons.nvda-project.org
To send a message to the list: nvda-addons@xxxxxxxxxxxxx
To change your list settings/unsubscribe:
//www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for
reporting bugs.
Community addons are available from: http://addons.nvda-project.org
To send a message to the list: nvda-addons@xxxxxxxxxxxxx
To change your list settings/unsubscribe:
//www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
