7 new commits in wintenApps:
https://bitbucket.org/nvdaaddonteam/wintenapps/commits/bdc00833a9ac/
Changeset: bdc00833a9ac
Branch: None
User: josephsl
Date: 2019-11-26 21:00:07+00:00
Summary: Settings: use Python 3.7's
sys.getwindowsversion().platform_version tuple for Storage Sense workaround.
Python 3.7 includes a new tuple named 'platform_version', returning major,
minor, and build of a Windows version. Since Version 1909 is really build 18362
with things on top, use platform version tuple (exposed via
winVersion.winVersion tuple) to handle both 1903 and 1909 when it comes to
Storage Sense combo box workaround.
With this commit, NVDA 2019.3 is now a requirement.
Affected #: 1 file
diff --git a/addon/appModules/systemsettings.py
b/addon/appModules/systemsettings.py
index b76b5de..abeae98 100755
--- a/addon/appModules/systemsettings.py
+++ b/addon/appModules/systemsettings.py
@@ -62,7 +62,8 @@ class AppModule(AppModule):
if isinstance(obj, UIA):
# In 18200 series and above, various Storage Sense
option combo boxes have values but are not exposed as such, so treated it as
combo box without value pattern.
# Resolved in 18800 and above, which means Version 1903
(build 18362) and 1909 (build 18363) will still carry this problem.
- if winVersion.winVersion.build in (18362, 18363) and
obj.role == controlTypes.ROLE_COMBOBOX and
obj.UIAElement.cachedAutomationID.startswith("SystemSettings_StorageSense_SmartPolicy_"):
+ # Note that 1909 is still 18362 internally, so just
check platform version tuple (Python 3.7 and later).
+ if winVersion.winVersion.platform_version == (10, 0,
18362) and obj.role == controlTypes.ROLE_COMBOBOX and
obj.UIAElement.cachedAutomationID.startswith("SystemSettings_StorageSense_SmartPolicy_"):
clsList.insert(0, ComboBoxWithoutValuePattern)
# Sometimes, the same text is announced, so consult this cache.
https://bitbucket.org/nvdaaddonteam/wintenapps/commits/577234e572c4/
Changeset: 577234e572c4
Branch: None
User: josephsl
Date: 2019-11-26 21:01:52+00:00
Summary: Feedback hub: remove notificaiton event workaournd for categories.
Due to yet another user interface/experience redesign: notification issue for
categories is either no longer present or was minimized in recent Feedback hub
releases, so remove the notification event workaround. This makes the app
module unnecessary - the app module itself will be removed in a future release.
Affected #: 1 file
diff --git a/addon/appModules/pilotshubapp.py b/addon/appModules/pilotshubapp.py
index 9aab478..918b83d 100644
--- a/addon/appModules/pilotshubapp.py
+++ b/addon/appModules/pilotshubapp.py
@@ -10,5 +10,4 @@ from NVDAObjects.UIA import UIA
class AppModule(appModuleHandler.AppModule):
def event_UIA_notification(self, obj, nextHandler, activityId=None,
**kwargs):
- if activityId in ("CategoryChangedContext",): return
nextHandler()
https://bitbucket.org/nvdaaddonteam/wintenapps/commits/0f5e49439c27/
Changeset: 0f5e49439c27
Branch: None
User: josephsl
Date: 2019-11-27 17:03:31+00:00
Summary: Readme: 20H1 = 2004, modern keyboard intro text removed.
Affected #: 1 file
diff --git a/readme.md b/readme.md
index 242541f..bc4c93f 100755
--- a/readme.md
+++ b/readme.md
@@ -67,7 +67,7 @@ Most items are no longer applicable on Version 1903 and
later. Classic Cortana r
* Textual responses from Cortana (both Classic and Conversations UI) are
announced in most situations (if using Classic Cortana, reopen Start menu and
try searching again if responses are not announced).
* NVDA will be silent when talking to Cortana via voice.
* In Classic Cortana, NVDA will announce reminder confirmation after you set
one.
-* In Version 1909 (November 2019 Update) and 20H1 build 18945 and later,
modern search experience in File Explorer powered by Windows Search user
interface is supported.
+* In Version 1909 (November 2019 Update) and later, modern search experience
in File Explorer powered by Windows Search user interface is supported.
## Feedback Hub
@@ -98,12 +98,10 @@ This refers to classic EdgeHTML-based Microsoft Edge.
## Modern keyboard
-Most features below are now part of NVDA 2018.3 or later.
-
-* Support for Emoji input panel in Version 1709 (Fall Creators Update) and
later, including the redesigned panel in Version 1809 (build 17661 and later)
and changes made in 19H1 (build 18262 and later, including kaomoji and symbols
categories in build 18305). This is also applicable in build 18963 and later as
the app has been renamed. If using NVDA releases earlier than 2018.4, for best
experience when reading emojis, use Windows OneCore speech synthesizer. If
2018.4 or later is in use, enable Unicode Consortium setting from NvDA's speech
settings and set symbol level to "some" or higher.
+* Support for Emoji input panel in Version 1709 (Fall Creators Update) and
later, including redesigned panel in Version 1809 (build 17661 and later) and
changes made in Version 1903 (build 18262 and later, including kaomoji and
symbols categories in build 18305). This is also applicable in Version 2004
(build 18963 and later) as the app has been renamed. For best experience,
enable Unicode Consortium setting from NvDA's speech settings and set symbol
level to "some" or higher. All of these changes will be part of NVDA 2019.3.
* NVDA will no longer announce "clipboard" when there are items in the
clipboard under some circumstances.
* On some systems running Version 1903 (May 2019 Update) and later, NVDA will
no longer appear to do nothing when emoji panel opens.
-* Added support for modern Chinese, Japanese, and Korean (CJK) IME candidates
interface introduced in 20H1 build 18965 and later.
+* Added support for modern Chinese, Japanese, and Korean (CJK) IME candidates
interface introduced in Version 2004 (build 18965 and later).
## People
https://bitbucket.org/nvdaaddonteam/wintenapps/commits/cc3257252ffc/
Changeset: cc3257252ffc
Branch: None
User: josephsl
Date: 2019-11-27 17:11:12+00:00
Summary: Readme: more refined moern keyboard intro text and include a note
on Unicode Consortium setting for best emoji panel experience
Affected #: 1 file
diff --git a/readme.md b/readme.md
index bc4c93f..4b827b1 100755
--- a/readme.md
+++ b/readme.md
@@ -17,7 +17,7 @@ The following app modules or support modules for some apps
are included (see eac
* Maps
* Microsoft Edge
* Microsoft Store
-* Modern keyboard (emoji panel/dictation/hardware input suggestions/cloud
clipboard items in Version 1709 and later)
+* Modern keyboard (emoji panel/dictation/hardware input suggestions/cloud
clipboard history/modern input method editors in Version 1709 and later)
* People
* Settings (system settings, Windows+I)
* Weather.
@@ -98,8 +98,10 @@ This refers to classic EdgeHTML-based Microsoft Edge.
## Modern keyboard
-* Support for Emoji input panel in Version 1709 (Fall Creators Update) and
later, including redesigned panel in Version 1809 (build 17661 and later) and
changes made in Version 1903 (build 18262 and later, including kaomoji and
symbols categories in build 18305). This is also applicable in Version 2004
(build 18963 and later) as the app has been renamed. For best experience,
enable Unicode Consortium setting from NvDA's speech settings and set symbol
level to "some" or higher. All of these changes will be part of NVDA 2019.3.
-* NVDA will no longer announce "clipboard" when there are items in the
clipboard under some circumstances.
+This includes emoji panel, clipboard history, dictation, hardware input
suggestions, and modern input method editors for certain languages. When
viewing emojis, for best experience, enable Unicode Consortium setting from
NvDA's speech settings and set symbol level to "some" or higher.
+
+* Support for Emoji input panel in Version 1709 (Fall Creators Update) and
later, including redesigned panel in Version 1809 (build 17661 and later) and
changes made in Version 1903 (build 18262 and later, including kaomoji and
symbols categories in build 18305). This is also applicable in Version 2004
(build 18963 and later) as the app has been renamed. All of these changes will
be part of NVDA 2019.3.
+* When opening clipboard history, NVDA will no longer announce "clipboard"
when there are items in the clipboard under some circumstances.
* On some systems running Version 1903 (May 2019 Update) and later, NVDA will
no longer appear to do nothing when emoji panel opens.
* Added support for modern Chinese, Japanese, and Korean (CJK) IME candidates
interface introduced in Version 2004 (build 18965 and later).
https://bitbucket.org/nvdaaddonteam/wintenapps/commits/8216e6bd42e1/
Changeset: 8216e6bd42e1
Branch: None
User: josephsl
Date: 2019-11-27 20:08:10+00:00
Summary: Readme: modenr keyboard entries refined.
Affected #: 1 file
diff --git a/readme.md b/readme.md
index 4b827b1..7198135 100755
--- a/readme.md
+++ b/readme.md
@@ -17,7 +17,7 @@ The following app modules or support modules for some apps
are included (see eac
* Maps
* Microsoft Edge
* Microsoft Store
-* Modern keyboard (emoji panel/dictation/hardware input suggestions/cloud
clipboard history/modern input method editors in Version 1709 and later)
+* Modern keyboard (emoji panel/dictation/hardware input suggestions/cloud
clipboard history/modern input method editors)
* People
* Settings (system settings, Windows+I)
* Weather.
@@ -100,7 +100,7 @@ This refers to classic EdgeHTML-based Microsoft Edge.
This includes emoji panel, clipboard history, dictation, hardware input
suggestions, and modern input method editors for certain languages. When
viewing emojis, for best experience, enable Unicode Consortium setting from
NvDA's speech settings and set symbol level to "some" or higher.
-* Support for Emoji input panel in Version 1709 (Fall Creators Update) and
later, including redesigned panel in Version 1809 (build 17661 and later) and
changes made in Version 1903 (build 18262 and later, including kaomoji and
symbols categories in build 18305). This is also applicable in Version 2004
(build 18963 and later) as the app has been renamed. All of these changes will
be part of NVDA 2019.3.
+* Support for Emoji input panel in Version 1709 (Fall Creators Update) and
later, including redesigned panel in Version 1809 (build 17661 and later) and
changes made in Version 1903 (build 18262 and later, including kaomoji and
symbols categories in build 18305). This is also applicable in Version 2004
(build 18963 and later) as the app has been renamed. All of these changes are
now part of NVDA 2019.3.
* When opening clipboard history, NVDA will no longer announce "clipboard"
when there are items in the clipboard under some circumstances.
* On some systems running Version 1903 (May 2019 Update) and later, NVDA will
no longer appear to do nothing when emoji panel opens.
* Added support for modern Chinese, Japanese, and Korean (CJK) IME candidates
interface introduced in Version 2004 (build 18965 and later).
https://bitbucket.org/nvdaaddonteam/wintenapps/commits/c5ccee75018d/
Changeset: c5ccee75018d
Branch: None
User: josephsl
Date: 2019-11-29 02:32:56+00:00
Summary: Calculator: add additional UIA automation ID's to no announcements
list.
There are more uIA elements that raise name change event, which may become too
verbose. Thus add some more automation ID's to no announcements list.
Affected #: 1 file
diff --git a/addon/appModules/calculator.py b/addon/appModules/calculator.py
index 9c2d6b8..b5db79d 100755
--- a/addon/appModules/calculator.py
+++ b/addon/appModules/calculator.py
@@ -23,7 +23,11 @@ noCalculatorEntryAnnouncements = [
# Results display with Calculator set to compact overlay i.e. always on
top mode.
"CalculatorAlwaysOnTopResults",
# Calculator expressions with Calculator set to always on top mode.
- "ExpressionContainer"
+ "ExpressionContainer",
+ # Date range selector.
+ "ContentPresenter",
+ # Briefly shown when closing date calculation calendar.
+ "Light Dismiss",
]
https://bitbucket.org/nvdaaddonteam/wintenapps/commits/056d0971691f/
Changeset: 056d0971691f
Branch: stable
User: josephsl
Date: 2019-11-29 02:34:27+00:00
Summary: Calculator: rework name change handler to avoid verbose
announcements.
In version 10.1910, name change event is fired by results pane in compact
overlay mode. Thus forcefully suppress this. Also, Landmark Target element
should not announce things (seen when entering operators). Also, simplified
name changed event by ignoring non-UIA elements. This results in no more double
announcement of calculation results.
Affected #: 1 file
diff --git a/addon/appModules/calculator.py b/addon/appModules/calculator.py
index b5db79d..4196704 100755
--- a/addon/appModules/calculator.py
+++ b/addon/appModules/calculator.py
@@ -48,8 +48,12 @@ class AppModule(appModuleHandler.AppModule):
_resultsCache = ""
def event_nameChange(self, obj, nextHandler):
+ if not isinstance(obj, UIA): return
# No, announce value changes immediately except for calculator
results and expressions.
- if isinstance(obj, UIA) and obj.UIAElement.cachedAutomationID
not in noCalculatorEntryAnnouncements and obj.name != self._resultsCache:
+ if obj.UIAElement.cachedAutomationID in
noCalculatorEntryAnnouncements or obj.UIAElement.cachedClassName==
"LandmarkTarget":
+ self._shouldAnnounceResult = False
+ # For the rest:
+ elif obj.UIAElement.cachedAutomationID not in
noCalculatorEntryAnnouncements and obj.name != self._resultsCache:
# For unit conversion, UIA notification event presents
much better messages.
# For date calculation, live region change event is
also fired for difference between dates.
if obj.UIAElement.cachedAutomationID not in ("Value1",
"Value2", "DateDiffAllUnitsResultLabel"):
Repository URL: https://bitbucket.org/nvdaaddonteam/wintenapps/
--
This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.
