Thanks for the patch. I'll wait for others to discuss your points. John On Sun, Feb 26, 2012 at 01:31:34PM +0000, Mesar Hameed wrote: > Hi John, > > Please find attached patch that includes the updated harness. > > points of discussion: > > 1. should the expected braille be unicode braille chars, or is the > ascii-braille ok? > 2. if ascii then is "liblouis ascii-braille like encoding" the correct term? > from the updated documentation: > "The dots should be encoded in the liblouis ascii-braille like encoding." > > 3. The third test case in en-gb-g2_harness.py has been corrected, will submit > more test cases as time permits. > > Thank you for your review. > > Mesar > On Sun 26/02/12,06:04, John J. Boyer wrote: > > Hi Mesar, > > > > Thanks for updating the documentation. That is a big problem right now. > > > > Your improvements to the harness are great. > > > > I think a subdirectory of tests would be best for the harness. > > > > John > > > > On Sun, Feb 26, 2012 at 10:44:19AM +0000, Mesar Hameed wrote: > > > Hi John, > > > On Sun 26/02/12,04:17, John J. Boyer wrote: > > > > Hi Mesar, > > > > > > > > I've looked at your test harness. It looks good to me. > > > > > > Thank you for the review. > > > > > > I have improved the harness to include my area of intrest, which is > > > cursor positions and translation modes, which should help > > > us debug braille cursor problems which is what we often see in nvda and > > > orca. > > > I am just updating the documentation to include the test harness info, as > > > soon as that is done I will send the changes > > > to the list. > > > > > > > We already have a > > > > tests directory. The tests there check tables for validity. Your code > > > > checks for accuracy of transltion. Could the test harness be placed in > > > > the tests directory? > > > > > > Yes sure, do you want it directly in tests, or in tests/harness > > > I ask this because we will potentially have many harness files, one for > > > each table. > > > > > > Thanks. > > > Mesar > > > For a description of the software, to download it and links to > > > project pages go to http://www.abilitiessoft.com > > > > -- > > John J. Boyer; President, Chief Software Developer > > Abilitiessoft, Inc. > > http://www.abilitiessoft.com > > Madison, Wisconsin USA > > Developing software for people with disabilities > > > > For a description of the software, to download it and links to > > project pages go to http://www.abilitiessoft.com -- John J. Boyer; President, Chief Software Developer Abilitiessoft, Inc. http://www.abilitiessoft.com Madison, Wisconsin USA Developing software for people with disabilities For a description of the software, to download it and links to project pages go to http://www.abilitiessoft.com